RequireJS - calling functions within the same file

Question

I'm trying to call a function as a callback from another function within the same file.

Code below, shows no errors, but does nothing - is there a different/better way to do this?

I'm calling first function from require config file (require-main.js) and that works fine

define(['require-main'], function() {
    require(['getJSON'], function(getJSON) {
        getJSON.stations();
    });
});

getJSON.js

define(['jquery', 'domChange', 'setUp'], function($, domChange, setUp) {
    var self = this;
    return {

        stations: function() {    
            $.get('/js/ajax/stations.json', function(sol) { /* local JSON */
                tmv.stations = sol;
                console.log(sol); /* this is fine */
                self.lines; /* <-- call next function */
            });
        },

        lines: function() {
            console.log('foo'); /* NOT called */
            $.get('/js/ajax/lines.json', function(lines) { /* local JSON */
                /* do something */
            });
        }
    }
});

I've seen this question but I can't work this way as the order is not predetermined

Update: as above, tried caching this into var but still no joy

this.lines this is the reference of the function, you are not actually calling it — Francesco
– Francesco, Commented Aug 4, 2016 at 7:45

metal03326 · Accepted Answer · 2016-08-04 08:02:35Z

3

Try this for the contents of your getJSON.js:

define(['jquery', 'domChange', 'setUp'], function($, domChange, setUp) {
    var getJSON = {

        stations: function() {    
            $.get('/js/ajax/stations.json', function(sol) { /* local JSON */
                tmv.stations = sol;
                console.log(sol); /* this is fine */
                getJSON.lines(); /* <-- call next function */
            });
        },

        lines: function() {
            console.log('foo'); /* NOT called */
            $.get('/js/ajax/lines.json', function(lines) { /* local JSON */
                /* do something */
            });
        }
    }
    return getJSON;
});

answered Aug 4, 2016 at 8:02

metal03326

1,2632 gold badges13 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ivan Shmidt · Accepted Answer · 2016-08-04 07:51:19Z

1

Should be

tmv.stations = sol; console.log(sol); /* this is fine */ this.lines(); /* <-- Actually calls the function */

answered Aug 4, 2016 at 7:51

Ivan Shmidt

561 bronze badge

Comments

Olivier Boissé · Accepted Answer · 2016-08-04 07:58:30Z

0

Maybe you should keep the reference to this keyword before calling the ajax function

stations: function() {    
        var self = this;
        $.get('/js/ajax/stations.json', function(sol) { /* local JSON */
            tmv.stations = sol;
            console.log(sol); /* this is fine */
            self.lines(); /* <-- call next function */
        });
 }

edited Aug 4, 2016 at 7:58

answered Aug 4, 2016 at 7:58

Olivier Boissé

18.6k7 gold badges54 silver badges71 bronze badges

2 Comments

Francesco Over a year ago

he already does, and anyway this refer to the object in that case, not to the function

Olivier Boissé Over a year ago

@Francescoes. BTW his var self = this is not at the same placed, I think my solution should work.

Collectives™ on Stack Overflow

RequireJS - calling functions within the same file

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related