Angular: Trying to return JSON data is causing a error in my service?

Question

Trying to return JSON data is causing a error in my service. Here is the code...looks simple enough!

var app = angular.module('easyjet', []);

app.service('FlightsService', function($http) {

    return {
        'selectedResult': null,
        'resultsData': $http.get('http://ejtestbed.herokuapp.com/flights')
    };

});

app.controller('ResultsController', function($scope, FlightsService) {

    // Default sort setting
    $scope.order = "flightNumber.number";

    // Using service
    $scope.flights = FlightsService;
});

app.controller('DetailedFlightController', function($scope, FlightsService) {

    // Using service
    $scope.flights = FlightsService;

});

How can I fix this? Thanks in advance

@Rob The problem is the array its looking for is not being loaded in 'resultsData' in my code — Nasir
– Nasir, Commented Aug 4, 2016 at 16:11
Http requests are asynchronous actions, meaning that they will finish at some point in time after beeing called, succesfully or not. Because data can be returned at some point in time $http.get will return a $promise. Basically saying i will return something at some point. You have 2 callback possibilities 1.success 2.error. $promise.then(function(data){//success;},function(){//err;}). As for the usage @Rob provided a really good fiddle for your case, namely FlightsService.resultsData().then(function(response) {//do smth wih your data}); — Stefan.B
– Stefan.B, Commented Aug 4, 2016 at 16:51

Rob · Accepted Answer · 2016-08-04 16:19:12Z

1

Your resultsData property needs to return a function, not an $http request:

Working example: https://jsfiddle.net/yh26oey6/

 return {
  'selectedResult': null,
  'resultsData': function() {
    return $http.get('https://api.zippopotam.us/us/90210');
  }

And, without seeing how you're calling the service, there could be other issues also.

answered Aug 4, 2016 at 16:19

Rob

1,8502 gold badges12 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rob Over a year ago

Your controller is not calling the resultsData function, it's just referencing the service. Take a look at the fiddle link in my answer to get a better idea of how this could work.

Collectives™ on Stack Overflow

Angular: Trying to return JSON data is causing a error in my service?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related