AngularJS view doesn't update when replacing value

Question

I have the following html:

<input type="text" ng-model="skype" ng-change="checkInput('skype')">

the function is:

$scope.checkInput = function(value) {
    var string = $scope[value],
        pattern = /[^a-zA-Z]+/g;

    string = string.replace(pattern, '');
}

Now the console.log shows, that the string replaced successfully, however the view doesn't update. The strangest part is when using substring the view updates!

string = string.substring(0, 10);

What's wrong?

No idea but -- this is a bit unorthodox -- add a last line to your function that says $scope.$apply();. — Roy Dictus
– Roy Dictus, Commented Aug 8, 2016 at 9:40
$scope.$apply() needs when you are working on third parties libraries. — Jorawar Singh
– Jorawar Singh, Commented Aug 8, 2016 at 9:42
replace in your checkInput function var string = $scope[value] by var string =value; and then try it — lazyCoder
– lazyCoder, Commented Aug 8, 2016 at 9:45

Jorawar Singh · Accepted Answer · 2017-01-04 04:09:28Z

6

You are not setting any value to scope in order to angular can watch and react on that, your function is doing something but never setting value to scope.

$scope.checkInput = function(value) {
    var string = $scope[value],
        pattern = /[^a-zA-Z]+/g;

    $scope.skype = string.replace(pattern, '');
}

edited Jan 4, 2017 at 4:09

answered Aug 8, 2016 at 9:39

Jorawar Singh

7,6414 gold badges29 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Artem Z Over a year ago

Jorawar Singh, thank you, that's exactly what I needed. What about substring? Why does it work?

Jorawar Singh Over a year ago

you are replacing the sting like string = string.substring(0, 10); and that's correct but you were not setting it to scope. var i = 10; 10 = 5; now i is 5. you have changed the original value.

Collectives™ on Stack Overflow

AngularJS view doesn't update when replacing value

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related