Its not validating on my submit button click using javascript

Question

I have this code in my view

function Validate() {
   if (document.getElementById('MandateName').value == "") {

       var err = document.getElementById('MandateNameErr');
       err.innerHTML = "Please enter a value for the Mandate Name";
       err.style.display = "block";
       return false;
   }
   else {
       document.getElementById('MandateNameErr').style.display = "none";
   }

   if (document.getElementById('MandateDescription').value == "") {
       var err = document.getElementById('MandateDescriptionErr');
       err.innerHTML = "Please enter a value for the Mandate Description";
       err.style.display = "block";
       return false;
   }
   else {
       document.getElementById('MandateDescriptionErr').style.display = "none";
   }

   return true;
}

and I have on submit button I am validating before submiting?

<button name="Submit" onclick="Validate()" >Add Variables to Mandate</button>

I called Validate function but its showing me if I am not entering anything on the text box if I click Button its showing me my validation message but same time its going to my view and throwing me the message?

even I put the return false; its not working is that something I am doing wrong?

Why did you remove the code? The question doesn't make nearly as much sense now... — Nick Craver
– Nick Craver, Commented Oct 7, 2010 at 15:53

Nick Craver · Accepted Answer · 2010-10-07 15:42:07Z

3

You need to put return in the onclick, like this:

<button name="Submit" onclick="return Validate()" >Add Variables to Mandate</button>

Otherwise you're executing the validation...but not really caring about the result.

answered Oct 7, 2010 at 15:42

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

AlwaysAProgrammer Over a year ago

@Nick......forgetting the return, is the most common mistake in calling js functions

Ruan Mendes Over a year ago

The most common mistake? How about a very common mistake in a deprecated style of attaching events? If you separate your script from the html, this won't happen.

Nick Craver Over a year ago

@Juan - While I agree, I find fault with your argument, $("button").click(function() { Validate(); }); would have the exact same issue, it would need to be $("button").click(function() { return Validate(); }); or $("button").click(Validate);

Ruan Mendes Over a year ago

I see... I guess returning false to prevent the default action is what should be deprecated, in favor of preventDefault

Collectives™ on Stack Overflow

Its not validating on my submit button click using javascript

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related