Issue running INSERT command using OleDbCommand in C#

Question

I have the following which looks to be ok, but for some reason it's throwing ORA-00936: missing expression

...
var query = "INSERT INTO MY_TABLE VALUES (@id, @filepath, @filename, @filesize, @md5)";

using (var insertCmd = new OleDbCommand(query, conn))
{
    insertCmd.CommandType = CommandType.Text;
    insertCmd.Parameters.AddRange(new OleDbParameter[]
    {
        new OleDbParameter("@id", FindItemId(filePath)),
        new OleDbParameter("@filepath", filePath),
        new OleDbParameter("@filename", new FileInfo(filePath).Name),
        new OleDbParameter("@filesize", new FileInfo(filePath).Length),
        new OleDbParameter("@md5", GetMd5Hash(filePath))
    });
    insertCmd.ExecuteNonQuery();
}
...

In debug, I can see the parameter values are binded correctly. So what am I doing wrong?

Any help would be greatly appreciated.

@HiteshThakor The image above is generated from a try catch exception. — Magic Mick
– Magic Mick, Commented Aug 9, 2016 at 4:54

Divya · Accepted Answer · 2016-08-09 07:20:33Z

1

What Mick said above is correct.

OleDbCommand and OdbCommand does not support named parameters and uses the ? placeholder instead, so the order of the parameters is important. However, you can give names to its parameters instead of using ?, for readability purposes like below:

...
var query = "INSERT INTO MY_TABLE VALUES (?, ?, ?, ?, ?)";

using (var insertCmd = new OleDbCommand(query, conn))
{
insertCmd.CommandType = CommandType.Text;
insertCmd.Parameters.AddRange(new OleDbParameter[]
{
    new OleDbParameter("@id", FindItemId(filePath)),
    new OleDbParameter("@filepath", filePath),
    new OleDbParameter("@filename", new FileInfo(filePath).Name),
    new OleDbParameter("@filesize", new FileInfo(filePath).Length),
    new OleDbParameter("@md5", GetMd5Hash(filePath))
});
insertCmd.ExecuteNonQuery();
}
...

answered Aug 9, 2016 at 7:20

Divya

4365 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:08:06Z

0

Ok found the answer here

Apparently need to use ? for binding with OLEDB in ORACLE 0_o

The following works..

...
var query = "INSERT INTO MY_TABLE VALUES (?, ?, ?, ?, ?)";

using (var insertCmd = new OleDbCommand(query, conn))
{
    insertCmd.CommandType = CommandType.Text;
    insertCmd.Parameters.AddRange(new OleDbParameter[]
    {
        new OleDbParameter("?", FindItemId(filePath)),
        new OleDbParameter("?", filePath),
        new OleDbParameter("?", new FileInfo(filePath).Name),
        new OleDbParameter("?", new FileInfo(filePath).Length),
        new OleDbParameter("?", GetMd5Hash(filePath))
    });
    insertCmd.ExecuteNonQuery();
}
...

edited May 23, 2017 at 12:08

CommunityBot

11 silver badge

answered Aug 9, 2016 at 5:26

Magic Mick

1,5531 gold badge22 silver badges33 bronze badges

Collectives™ on Stack Overflow

Issue running INSERT command using OleDbCommand in C#

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related