Configure Simple Injector to support resolving ASP.NET Core middleware dependencies?

Question

How can I configure SimpleInjector to resolve LogMiddleware's Invoke method dependency, like IMessageService ?

As I know, Asp.net core uses HttpContext.RequestServices (IServiceProvider) to resolve dependencies, I set SimpleInjector container to HttpContext.RequestServices property but didn't work. I want to change ServiceProvider dynamically because each tenant should have a container.

public class LogMiddleware
{
    RequestDelegate next;
    private readonly ILogger log;

    public LogMiddleware(RequestDelegate next, ILoggerFactory loggerFactory)
    {
        this.next = next;
        this.log = loggerFactory.CreateLogger<LogMiddleware>();
    }

    public async Task Invoke(HttpContext context, IMessageService messageService)
    {
         await context.Response.WriteAsync(
                messageService.Format(context.Request.Host.Value));
    }
}

public interface IMessageService
{
    string Format(string message);
}

public class DefaultMessageService : IMessageService
{
  public string Format(string message)
  {
    return "Path:" + message;
  }
}

I don't understand exactly what your problem is. What prevents you from using your middleware? — Steven
– Steven, Commented Aug 12, 2016 at 19:05
How can I resolve middleware's dependencies from simple injector? — oguzh4n
– oguzh4n, Commented Aug 14, 2016 at 11:27

Steven · Accepted Answer · 2016-08-14 12:53:50Z

You can use your LogMiddleware class as follows:

applicationBuilder.Use(async (context, next) => {
    var middleware = new LogMiddleware(
        request => next(),
        applicationBuilder.ApplicationServices.GetService<ILoggerFactory>());

    await middleware.Invoke(context, container.GetInstance<IMessageService>());
});

I however advise you to change your middleware class a little bit. Move the runtime data (the next() delegate) out of the constructor (since components should not require runtime data during construction), and move the IMessageService dependency into the constructor. And replace the ILoggerFactory with a ILogger dependency, since an injection constructor should do no more than store its incoming dependencies (or replace ILogger with your own application-specific logger abstraction instead).

Your middleware class will then look as follows:

public sealed class LogMiddleware
{
    private readonly IMessageService messageService;
    private readonly ILogger log;

    public LogMiddleware(IMessageService messageService, ILogger log) {
        this.messageService = messageService;
        this.log = log;
    }

    public async Task Invoke(HttpContext context, Func<Task> next) {
        await context.Response.WriteAsync(
            messageService.Format(context.Request.Host.Value));

        await next();
    }
}

This allows you to use your middleware as follows:

var factory = applicationBuilder.ApplicationServices.GetService<ILoggerFactory>();

applicationBuilder.Use(async (context, next) => {
    var middleware = new LogMiddleware(
        container.GetInstance<IMessageService>(),
        factory.CreateLogger<LogMiddleware>());

    await middleware.Invoke(context, next);
});

Or in case you registered the ILogger (or your custom logging abstraction) in Simple Injector, you can do the following:

applicationBuilder.Use(async (context, next) => {
    var middleware = container.GetInstance<LogMiddleware>();
    await middleware.Invoke(context, next);
});

dotnetstep · Accepted Answer · 2016-08-13 02:26:03Z

0

There is two problem with your code.

Your "DefaultMessageService" does not implement interface "IMessageService". It should be like this.

 public class DefaultMessageService : IMessageService
 {
 public string Format(string message)
{
   return "Path:" + message;
 }
}

You have to register DefaultMessageService in ConfigureService in Startup.cs.

 public void ConfigureServices(IServiceCollection services)
        {
            // Add framework services.
            services.AddMvc();
            services.AddSingleton<IMessageService>(new DefaultMessageService());
        }

answered Aug 13, 2016 at 2:26

dotnetstep

17.5k6 gold badges62 silver badges80 bronze badges

1 Comment

oguzh4n Over a year ago

sorry I forgot to write IMessageService when creating question.

Collectives™ on Stack Overflow

Configure Simple Injector to support resolving ASP.NET Core middleware dependencies?

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related