PHP MySQL Update query array(0) { }

Question

Can anybody help me to understand why my query update dosen't update my data in my database.

This my code php :

<?php

$code = $_GET['code'];
$n1= $_GET['n1'];
$n2= $_GET['n2'];
$n3 = $_GET['n3'];

try {
  $connexion= new PDO('mysql:host=localhost;dbname=data','mydata','password');
  $sql_update = "UPDATE data.check SET  numb_1='".$n1."',numb_2='".$n2."','numb_3'='".n3."' WHERE 'code_product' =".$code;
  $query = $connexion-> prepare($sql_update);
  $query -> execute();
  $data_update= $query -> fetchAll(PDO::FETCH_ASSOC);
}

catch(PDOException $e)
{
 echo "<br>" . $e->getMessage();
}

Thanks for any help.

you are using update.you should use select to return any data — Vikas Umrao
– Vikas Umrao, Commented Aug 17, 2016 at 9:23
Also think about what happens if I send ...&code=0%20or%201=1 in the GET request. This code is wide open to SQL injection. — Phylogenesis
– Phylogenesis, Commented Aug 17, 2016 at 9:28
I think you got enough time to go through the answer given below. Atleast respond to the answer @ZouZou. — Nana Partykar
– Nana Partykar, Commented Aug 17, 2016 at 12:50

Nana Partykar · Accepted Answer · 2016-08-17 13:50:27Z

2

1) Change

$sql_update = "UPDATE data.check SET  numb_1='" . $n1 . "',numb_2='" . $n2 . "','numb_3'='" . n3 . "' WHERE 'code_product' =" . $code;

To

$sql_update = "UPDATE data.check SET  numb_1='" . $n1 . "',numb_2='" . $n2 . "','numb_3'='" . $n3 . "' WHERE `code_product` =" . $code;

=> In n3 you forgot to add $. And, replace single quotes with backtick to enclose column name.

Updated Code

<?php

$code = $_GET['code'];
$n1 = $_GET['n1'];
$n2 = $_GET['n2'];
$n3 = $_GET['n3'];

try {

  $connexion = new PDO('mysql:host=localhost;dbname=data', 'mydata', 'password');

  $sql_update = $connexion->prepare("UPDATE `data`.`check` SET numb_1 = :numb_1 , numb_2 = :numb_2, numb_3 = :numb_3 WHERE `code_product` = :code_product");
  $sql_update->execute(array(':numb_1' => $n1,':numb_2'=>$n2, ':numb_3'=>$n3,':code_product'=>$code));


  $stmt = $connexion->prepare("SELECT * FROM `data`.`check` WHERE code_product=:code_product");
  $stmt->execute(array(':code_product'=>$code));
  $data_update= $stmt -> fetchAll(PDO::FETCH_ASSOC);

} catch (PDOException $e) {
  echo "<br>" . $e->getMessage();
}
?>

edited Aug 17, 2016 at 13:50

answered Aug 17, 2016 at 9:30

Nana Partykar

10.5k10 gold badges50 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Ivan Over a year ago

Why do you have mysqli and pdo?

Nana Partykar Over a year ago

My Bad @Ivan . Thanks For Pointing Out.

zouzou Over a year ago

I have a problem PDO not throwing exception with unbound parameters

Nana Partykar Over a year ago

Why you want to throw exception? Code is working or not? Data coming or not @zouzou.?

zouzou Over a year ago

@NanaPartykar data is not coming :(

|

Rohan Kumar · Accepted Answer · 2016-08-22 04:30:26Z

1

After your update execution you need to query again for fetching result like,

$sql_update = "UPDATE data.check SET  numb_1='".$n1."',numb_2='".$n2."','numb_3'='".$n3."' WHERE 'code_product' =".$code;
$query = $connexion-> prepare($sql_update);
$query -> execute();

$query = $dbh->prepare("SELECT * FROM data.check");
$query->execute();
$data_update= $query -> fetchAll(PDO::FETCH_ASSOC);// now it will get records

edited Aug 22, 2016 at 4:30

answered Aug 17, 2016 at 9:28

Rohan Kumar

40.7k11 gold badges81 silver badges111 bronze badges

1 Comment

Ivan Over a year ago

Why not just have one query with two statements (UPDATE and SELECT)?

Collectives™ on Stack Overflow

PHP MySQL Update query array(0) { }

2 Answers 2

8 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related