using header function inside a loop

Question

<?php
$a = array('f-stat,porcelain mask'=>'jay azima','jay azima,oil painting'=>'japanese doll');
$msg="We can't recommend any items to you.";
foreach($a as $k=>$v)
{
  if($_GET['items']==$k)
  {
    header("location: hola.php?tequilla=".$v);
  }

}
header("location: hola.php?tequilla=".$msg);
?>

What I tried to do is if string from $_GET['items'] matches any of key in $a array, it is redirected to hola.php with $v value. Otherwise $msg string is passed. But the problem is even if the $k and $_GET['items'] matches, latter header function is executed with $msg value. Also if I remove the latter header function, the header function inside the loop works fine.

You need exit(); after the header lines so the script doesn't continue to run. — Jonnix
– Jonnix, Commented Aug 24, 2016 at 8:44
I prefer die(); ... I can be morbid like that - but it's the same thing. — CD001
– CD001, Commented Aug 24, 2016 at 8:45
Additionaly, you can use var_dump($_GET['items']); and trim() to make sure you do not have any spaces or to count characters while you are comparing string in your if condition. — Mittul Chauhan
– Mittul Chauhan, Commented Aug 24, 2016 at 8:47
I'm a rookie to coding. What's wrong with $_GET['items']==$k?. Tip me, I can use the help. Thank You. -@u_mulder — Azima
– Azima, Commented Aug 24, 2016 at 14:03

u_mulder · Accepted Answer · 2016-08-24 14:46:02Z

1

All your code simplified:

$a = array(
    'f-stat,porcelain mask'=>'jay azima',
    'jay azima,oil painting'=>'japanese doll'
);
$v = !empty($a[$_GET['items']])? $a[$_GET['items']] : "We can't recommend any items to you.";

header("Location: hola.php?tequilla=" . $v);
die();

edited Aug 24, 2016 at 14:46

answered Aug 24, 2016 at 9:01

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Azima Over a year ago

Is that extra ';' intentional after the array? The problem persists anyway. :(

u_mulder Over a year ago

No, I removed it. What is the problem now?

CD001 · Accepted Answer · 2016-08-24 08:55:22Z

0

Use exit() it stops the execution of the script. This will not redirect to second header.

<?php
    $a = array('f-stat,porcelain mask'=>'jay azima','jay azima,oil painting'=>'japanese doll');
    $msg="We can't recommend any items to you.";

    foreach($a as $k=>$v)
    {

      if($_GET['items']==$k)
      {
        header("location: hola.php?tequilla=".$v);
        exit(); // < this will stop the script before the 2nd header()
      }

    }

    header("location: hola.php?tequilla=".$msg);
    exit();

    ?>

edited Aug 24, 2016 at 8:55

CD001

8,5123 gold badges26 silver badges29 bronze badges

answered Aug 24, 2016 at 8:47

Manish

3,7051 gold badge23 silver badges24 bronze badges

4 Comments

Azima Over a year ago

the problem persists. Is is even okay to use header function inside the loop? Am I doing it wrong?

Manish Over a year ago

This is okay. Did you checked that $_GET['items'] value matched with $k ?

Azima Over a year ago

yeah.. i made it sure.. :)

Manish Over a year ago

Use trim function. May be space comes in your value.

Bhavik Hirani · Accepted Answer · 2016-08-24 08:51:01Z

0

try this

<?php
  $a = array('f-stat,porcelain mask'=>'jay azima','jay azima,oil painting'=>'japanese doll');
  $location = '';
  $msg="We can't recommend any items to you.";
  foreach($a as $k=>$v){
    if($_GET['items']==$k){
       $location = "hola.php?tequilla=".$v;
    }
  }
  if($location != ''){
     $location = "hola.php?tequilla=".$msg;
  }
  header("location: ".$location);
  exit(0);
?>

answered Aug 24, 2016 at 8:51

Bhavik Hirani

2,0264 gold badges32 silver badges50 bronze badges

1 Comment

Azima Over a year ago

the problem persists. Is is even okay to use header function inside the loop? Am I doing it wrong?

Collectives™ on Stack Overflow

using header function inside a loop

3 Answers 3

2 Comments

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related