Link button doesn't function in javascript

Question

I have this button in javascript .

 <a href="#" onclick="window.location.href = " ' + urlOfNewTask + ' "; return false;">{{"view_task"|translate}}</a>\

All I want to do is to close this modal after I click on it( for this I insert return false) and this button to take me to the link inside the onclick function. The problem is that when I click at the button nothing happens, nor close of the modal nor open the link. Have i done something wrong? Here is the variable :

var urlOfNewTask = mytaskbaseurl + "." + data.taskEscUrl;

try without the funky quotes!! "window.location.href = urlOfNewTask; return false;" or "window.location.href = 'urlOfNewTask'; return false;" if urlOfNewTask is a string literal and not some variable — Jaromanda X
– Jaromanda X, Commented Sep 6, 2016 at 10:49
here's a tip to writing inline javascript .... write it ... then add quotes around it - if you use single quotes in the script, use double quotes around it, and vice versa ... if you (have to) use both ' and " in the script - then escape the ones you surround the script inside the script — Jaromanda X
– Jaromanda X, Commented Sep 6, 2016 at 10:52

Abhijeet · Accepted Answer · 2016-09-06 10:53:34Z

1

Change onclick to onclick="window.location.href = 'urlOfNewTask'; return false;"

If urlOfNeTask is variable then try :

onclick="window.location.href = urlOfNewTask; return false;"

edited Sep 6, 2016 at 10:53

answered Sep 6, 2016 at 10:52

Abhijeet

4,3491 gold badge26 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Jaromanda X Over a year ago

assuming urlOfNewTask is the literal string urlOfNewTask, rather than some global variable (which seems to be the case)

Abhijeet Over a year ago

Yes. @JaromandaX you are right. So I updated my answer accordingly

Abhijeet Over a year ago

If url is variable and declared global then you can use second answer

Abhijeet Over a year ago

Can you add your html and javascript code it will help me solve your problem faster

Abhijeet Over a year ago

You can declare var urlOfNewTask globally so it can be accessed by onclick part.

Collectives™ on Stack Overflow

Link button doesn't function in javascript

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related