Stack overflow when creating TreeView

Question

I am getting a stack overflow, when I try to create a Tree View using WinForms.

private void createFeatureTree()
{
    FeatureTree.Nodes.Clear();
    FeatureTree.Nodes.Add(createTreeNode(new DirectoryInfo(starting directory path)));
}

private TreeNode createTreeNode(DirectoryInfo directory)
{
   var directoryNode = new TreeNode(directory.Name);
   foreach (var dir in directory.GetDirectories())
   {
       directoryNode.Nodes.Add(createTreeNode(directory));
   }

   foreach (var file in directory.GetFiles())
   {
       directoryNode.Nodes.Add(new TreeNode(file.Name));
   }

   return directoryNode;
}

createFeatureTree() is called on its own thread on the startup. How come I am getting a stack overflow error? Is there a limit to the amount of nodes that the TreeView can store?

I guess you mean directoryNode.Nodes.Add(createTreeNode(**dir**)); — L.B
– L.B, Commented Sep 6, 2016 at 21:55

Jure · Accepted Answer · 2016-09-06 21:59:35Z

2

Change a call

directoryNode.Nodes.Add(createTreeNode(directory));

to:

directoryNode.Nodes.Add(createTreeNode(dir));

And it should work. The reason you are getting "StackOverflowException" is that you always call createTreeNode method on directory variable passed in, not on its subdirectories (which, eventually, there would be none when you are at the leaf level).

Basicaly, if you pass in "C:\", you constantly call createTreeNode on "C:\" and it never ends.

answered Sep 6, 2016 at 21:59

Jure

1,1765 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

FyreeW Over a year ago

Ah, makes sense. Did not realize I had the original directory in there instead of the contained ones. Thank you for the help!

Collectives™ on Stack Overflow

Stack overflow when creating TreeView

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related