if/else type statements within java

Question

I am trying to determine upon startup whether the in-app has been purchased, this is my current code;

if (!(getSharedPreferences("purchased", 0).getBoolean("purchased", false)))
admob();        
Log.d("NOT UPGRADED", "SHOW AD AS UPGRADED ALREADY");
if (!(getSharedPreferences("purchased", 0).getBoolean("purchased", true)))
admobskip();    
Log.d("UPGRADED", "DO NOT SHOW AD AS UPGRADED ALREADY");

But it appears to run through all that code, rather than checking, with iOS I use if / else , however I seem unable to use that and wanted the java equivelent for this piece of code if possible? I have swapped the purchased to 'true' on the second half of statement.

Less idiosyncratic indentation would certainly help us, and probably, in time, you as well. — Bathsheba
– Bathsheba, Commented Sep 22, 2016 at 11:38
Note that your Log.d statements are not part of the if statements, so they are always executed. — Eran
– Eran, Commented Sep 22, 2016 at 11:38

Bathsheba · Accepted Answer · 2016-09-22 11:39:18Z

3

If you only want statements to run if an if condition passes, then use scope blocks { and } around that code:

if (condition){
    /*run all these statements*/
}

If you don't use the braces then only the following single statement is part of the if: that's what's happening in your case.

(Personally I always use braces as I believe that's a clearer style, but not everyone does that).

answered Sep 22, 2016 at 11:39

Bathsheba

235k35 gold badges376 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Hypergater Over a year ago

Very helpful, thank you very much, explained well also!

Alamri · Accepted Answer · 2016-09-22 11:45:58Z

1

Use this instead

if (getSharedPreferences("purchased", 0).getBoolean("purchased",false) == false) {
   admob();        
   Log.d("NOT UPGRADED", "SHOW AD AS UPGRADED ALREADY");
} else if (getSharedPreferences("purchased", 0).getBoolean("purchased",true) == true) {
   admobskip();    
   Log.d("UPGRADED", "DO NOT SHOW AD AS UPGRADED ALREADY");
}

answered Sep 22, 2016 at 11:45

Alamri

2,2022 gold badges17 silver badges21 bronze badges

10 Comments

Bathsheba Over a year ago

== true is a tautology.

Alamri Over a year ago

@Bathsheba just to make it clear to him as he's new to Java ;)

Hypergater Over a year ago

Thank you for this, you answered without prejudice, unfortunately some of the other guys have been a bit harsh considering I am new to this, thank you once more! :)

Bathsheba Over a year ago

Come on, we're a nice bunch of folk ;-)

Bathsheba Over a year ago

@Alamri: Absolutely I agree. Too many folk are downvoting on the grounds of "obviousnesss". That is never a reason to downvote. And it's getting steadily worse.

|

Collectives™ on Stack Overflow

if/else type statements within java

2 Answers 2

1 Comment

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related