Show dialogbox only once in a for loop - Closed

Question

This code works fine except multiple dialog box prompt when there are multiple empty textbox but I only want it to prompt once.

For example, if I enter 1,1,(null),(null),d,g, dialog box will prompt twice since there is two empty textboxes but I only need it to prompt once.

How can I solve this problem?

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
    {
        for (int i = 0; i < e.MasterRecord.DetailCount; i++)
        {
            if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
            {
        MessageBox.Show("You left Your PO No empty. Please check it carefully.");
            }
        }
    }

After observing other answers, I think your BeforeSave method is being called at least two times. In this case, showing message box only once will require a flag which is outside of BeforeSave method. So, you should either post the code from where this method is being called or verify yourself that - you want to call BeforeSave multiple times. — Kamalesh Wankhede
– Kamalesh Wankhede, Commented Sep 26, 2016 at 4:57
@krw12572 I did try adding a flag as bellow those answer they giving but the result still same. — ChengWan
– ChengWan, Commented Sep 26, 2016 at 6:06

Yeldar Kurmangaliyev · Accepted Answer · 2016-09-26 03:47:47Z

2

You can simply introduce a flag:

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
{
    bool hasEmpty = false;

    for (int i = 0; i < e.MasterRecord.DetailCount; i++)
    {
        if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
        {
            hasEmpty = true;
        }
    }

    if (hasEmpty) {
        MessageBox.Show("You left Your PO No empty. Please check it carefully.");
    }
}

answered Sep 26, 2016 at 3:47

Yeldar Kurmangaliyev

34.3k13 gold badges64 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Leon Bambrick Over a year ago

If it's showing twice, then BeforeSave might be getting called twice?

ChengWan Over a year ago

@LeonBambrick if user key in 3 empty "po no" it will prompt 3 time.It will follow how many empty "PO No".. any suggestion?

Theraot · Accepted Answer · 2016-09-26 04:22:47Z

2

Why not break out of the loop so that it stops checking?

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
{
    for (int i = 0; i < e.MasterRecord.DetailCount; i++)
    {
        if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
        {
            MessageBox.Show("You left Your PO No empty. Please check it carefully.");
            break; // <--
        }
    }
}

return will also work in this situation.

Test if BeforeSave is running twice:

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
{
    MessageBox.Show("Test"); // <--
    for (int i = 0; i < e.MasterRecord.DetailCount; i++)
    {
        if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
        {
            MessageBox.Show("You left Your PO No empty. Please check it carefully.");
            break; // <--
        }
    }
}

As yo can see I added a new "Test" message at the top of the method (outside the loop), if you see duplicate "Test" messages when using the code, it means that BeforeSave is running twice.

In that case you need to look at why it is running twice, and then fix that. If that is not fixable, then there could be some syncronization solution... such as:

private int canSave;

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
{
    if (Interlocked.CompareExchange(ref canSave, 0, 1) != 1)
    {
        // Any cancelation logic that's appropiate here
        return;
    }
    for (int i = 0; i < e.MasterRecord.DetailCount; i++)
    {
        if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
        {
            MessageBox.Show("You left Your PO No empty. Please check it carefully.");
            break; // <--
        }
    }
}

Then you see canSave 1 to allow the code to run 0 to disallow it. The Interlocked operation will ensure that the code in BeforeSave will not run again until you set canSave to 1 somewhere in the code (it automatically sets it to 0 when it gets executed - no chance for multiple threads to mess it up).

Although I'm giving you a solution to control double execution of BeforeSave, if it is running twice than expected shows that there is some problem somewhere else, and you should be trying to fix that (unless it is third party code).

edited Sep 26, 2016 at 4:22

answered Sep 26, 2016 at 3:51

Theraot

41.2k7 gold badges70 silver badges107 bronze badges

4 Comments

Theraot Over a year ago

@ChengWan well, that's odd. I don't see why the code would continue in the loop after using break. I would think that there is some other code showing the message, maybe this "BeforeSave" method is running twice.

ChengWan Over a year ago

@Theroat firstly i'm appreciated what you explain to me. I did try MessageBox.Show("Test"); // <--but it didn't show up.

Theraot Over a year ago

@ChengWan didn't show up - not even once - and you did nothing differect? On what enviroment are you running the code? because now what I think is that you are running outdated code - that is, that the solutions posted haven't worked because the code failed to compile or failed to deploy (and thus you ended up testing an old version). Edit: debug with break points, put a break point at the start of BeforeSave - if you are running a different version the IDE will complain that the version of the source doesn't match, it will also tell you if BeforeSave is running multiple times.

ChengWan Over a year ago

@Theroat ya, it didn't show up not even once. I try to write in a software name "autocount" just some customize part. I do everytime I write will save and reopen the software.

Theraot · Accepted Answer · 2016-09-26 04:12:39Z

1

Either use a flag, or use Linq.

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e) {
    bool flag = false;
    for (int i = 0; i < e.MasterRecord.DetailCount; i++) 
    { 
        if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString())) 
        { 
            flag = true;
            break;
        } 
    } 
    if (flag)
        MessageBox.Show("You left Your PO No empty. Please check it carefully.");
}

I don't know enough of the used objects to offer a linq solution

edited Sep 26, 2016 at 4:12

Theraot

41.2k7 gold badges70 silver badges107 bronze badges

answered Sep 26, 2016 at 3:54

Gilad Naaman

6,60016 gold badges54 silver badges83 bronze badges

1 Comment

ChengWan Over a year ago

Bro thank for your effort.. I did try your code run well but the result still same prompt out 2 dialog.. any other solution?

Kamalesh Wankhede · Accepted Answer · 2016-09-26 07:20:52Z

1

Following way should work for you even if your BeforeSave method is getting called multiple times.

private bool _isMessageBoxShown;
public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e) 
{    
  for (int i = 0; i < e.MasterRecord.DetailCount; i++) 
  { 
    if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString())) 
    { 
        if(!_isMessageBoxShown)
        {
           _isMessageBoxShown = true;
           MessageBox.Show("You left Your PO No empty. Please check it carefully.");
           break;
        }
    } 
  }            
}

Just make sure that when you want your messagebox to be shown next time, you will need to set _isMessageBoxShown = false;.

answered Sep 26, 2016 at 7:20

Kamalesh Wankhede

1,50516 silver badges40 bronze badges

1 Comment

ChengWan Over a year ago

bro I tried already. is that a possible it's a "yes/no"dialog if the dialog show and i close it. so it will keep repeat call it out?

ChengWan · Accepted Answer · 2016-09-26 09:45:17Z

0

I found out another way to solve it.

public void BeforeSave(BCE.AutoCount.Invoicing.Sales.SalesOrder.SalesOrderBeforeSaveEventArgs e)
    {
        int tt = 0;
        for (int i = 0; i < e.MasterRecord.DetailCount; i++)
        {
            if (tt == 0)
            {
                if (String.IsNullOrEmpty(e.MasterRecord.GetDetailRecord(i).YourPONo.ToString()))
                {
                    MessageBox.Show("You left Your PO No empty. Please check it carefully.");
                    tt = 1;
                }
            }
        }
    }

answered Sep 26, 2016 at 9:45

ChengWan

3111 bronze badges

Collectives™ on Stack Overflow

Show dialogbox only once in a for loop - Closed

5 Answers 5

2 Comments

4 Comments

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

4 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related