C# binary search tree

Question

I was making a test case for some code on binary search tree my professor gave

public static void Main(string [] args)
{
    //on my prof's code, public class BinSearchTree<T>
    BinSearchTree<int> myTree = new BinSearchTree<int>();

    myTree.Insert(10);
    myTree.Insert(15);
    myTree.Insert(5);
    myTree.Insert(2);
    myTree.Insert(1);

    Console.WriteLine(myTree.ToString());
    Console.ReadKey();
}

It compiles, but it displays

BinSearchTree`1[System.Int32]

Can somebody tell me why it displays that?

my prof's code:

public class BinSearchTree<T> where T : IComparable<T>
{
private class OurTreeNode<T>
{
    public T Data { get; set; }
    public OurTreeNode<T> Left;
    public OurTreeNode<T> Right;
    public OurTreeNode(T d = default(T), OurTreeNode<T> leftnode = null, OurTreeNode<T> rightnode = null)
    {
        Data = d;
        Left = leftnode;
        Right = rightnode;
    }

    public override string ToString()
    {
        return Data.ToString();
    }
}
//...other methods

//prof's Insert method
public void Insert(T newItem)
{
    mRoot = Insert(newItem, mRoot);
}
private OurTreeNode<T> Insert(T newItem, OurTreeNode<T> pTmp)
{
    if (pTmp == null)
        return new OurTreeNode<T>(newItem, null, null);
    else if (newItem.CompareTo(pTmp.Data) < 0)
        pTmp.Left = Insert(newItem, pTmp.Left);
    else if (newItem.CompareTo(pTmp.Data) > 0)
        pTmp.Right = Insert(newItem, pTmp.Right);
    else
        throw new ApplicationException("...");

    return pTmp;
}
}

I tried adding a ToString() method after the Insert method but it gives me an error when I used foreach. Is there a way of displaying it without making too much extra methods?

Just loop all of your TreeNodes and print the Data property in which you store your values. — mybirthname
– mybirthname, Commented Sep 27, 2016 at 6:07
@Angela - See, you got the answer for now. But, to understand them, please prepare your own code for how to print the nodes of a binary-search-tree. — Am_I_Helpful
– Am_I_Helpful, Commented Sep 27, 2016 at 6:09
@Angela - Also, you didn't show the ToString() of BinSearchTree<T>, instead you showed the ToString() of OurTreeNode<T>! — Am_I_Helpful
– Am_I_Helpful, Commented Sep 27, 2016 at 6:11
You need to show us what you “tried adding” and what error it gave you. — Dour High Arch
– Dour High Arch, Commented Sep 28, 2016 at 1:15

Am_I_Helpful · Accepted Answer · 2016-09-27 05:55:07Z

1

The class is using the default (Object's) ToString() implementation. You have 2 options:

walk though the elements of the tree and print it yourself
ask the author to implement/override the ToString() method

edited Sep 27, 2016 at 5:55

Am_I_Helpful

19.2k7 gold badges53 silver badges76 bronze badges

answered Sep 27, 2016 at 5:48

hiho

811 silver badge3 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shaun Luttin · Accepted Answer · 2016-09-27 06:37:15Z

0

Can somebody tell me why it displays that?

It displays that because ToString() prints the type definition.

Default implementations of the Object.ToString method return the fully qualified name of the object's type. (from the docs)

For instance, the following short program prints System.Collections.Generic.List`1[System.Int32], which is the type of List<int>.

using System;
using System.Collections.Generic;

public class Program
{
    public static void Main(string[] args)
    {
        List<int> myTree = new List<int>();
        myTree.Add(10);
        Console.WriteLine(myTree.ToString());
    }
}

Here are the rudiments of how to override the ToString() method to produce some meaningful output.

using System;
using System.Collections.Generic;

public class Program
{
    public static void Main(string[] args)
    {
        BinSearchTree<int> myTree = new BinSearchTree<int>();
        myTree.Insert(10);
        myTree.Insert(15);
        Console.WriteLine(myTree.ToString());
    }
}

public class BinSearchTree<T> where T : IComparable<T>
{
    private List<T> values = new List<T>();

    // rest of class omitted for clarity

    public void Insert(T val) {
        values.Add(val);
    }

    public override string ToString() {
        var result = string.Empty;
        foreach(var v in values)
        {
            result += v + ", ";
        }

        return result;
    }
}

Output

10, 15,

edited Sep 27, 2016 at 6:37

answered Sep 27, 2016 at 5:48

Shaun Luttin

143k93 gold badges443 silver badges495 bronze badges

3 Comments

mrchooo Over a year ago

is there any way I can fix it?

Shaun Luttin Over a year ago

@Angela Yes. You need to override ToString(). See edits.

mrchooo Over a year ago

I edited the code above. my prof already has an insert method on his code and I tried to add a ToString method but foreach gives an error

captainsac · Accepted Answer · 2016-09-27 07:10:41Z

0

As you have created the object of BinaryTree Class and have not overridden the ToString() method inside BinaryTree Class. You have not created object of OurTreeNode class and not calling ToString() method overriden inside it. Hence it is giving you the default ToString() method output of BinaryTree Class.

BinSearchTree<int> myTree = new BinSearchTree<int>();

You are calling

Console.WriteLine(myTree.ToString());

answered Sep 27, 2016 at 7:10

captainsac

2,4903 gold badges29 silver badges51 bronze badges

Collectives™ on Stack Overflow

C# binary search tree

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related