How to free a dynamically allocated array of structs in c?

Question

I am learning C and I can't free a dynamically allocated array of structs. Here is my sample code:

typedef char Str50[50];

typedef struct exam {
    Str50 firstname;
    Str50 lastname;
    Str50 className;
    int score;
    Str50 date;
} Exam;

Exam *examDB

size_t allocateAndFreeTheStructArray {

    size_t numRecs = 100; //let's say the array contains 100 elements
    examDB = malloc(numRecs * sizeof * examDB); //this allocates the needed memory

    // the code below tries to free what malloc allocated
    for (size_t i = 0; i < numRecs; i++) {
        free(&examDB[i]);
    }
    free(examDB);
}

When I compile this for windows, everything works fine (it seems). When I compile the same piece of code on my mac using xcode, I get an error that says: "malloc: *** error for object 0x7fae610060d0: pointer being freed was not allocated"

How is that possible? I used malloc to create the array... What am I missing here?

krzaq · Accepted Answer · 2016-10-01 22:54:07Z

4

You allocated a flat array of 100 objects. You're then trying to free each object separately and the list at the end - that's a pattern used when you have an array of pointers to objects. In your case, you can't free just one object in a flat array.

You have two options. Keep the flat array and just call free once:

size_t numRecs = 100; 
examDB = malloc(numRecs * sizeof * examDB); 

free(examDB);

Or change examDB to a pointer to pointer to Exam to keep a list of pointers:

Exam **examDB;

and then this would be the valid code:

size_t numRecs = 100; 
examDB = malloc(numRecs * sizeof * examDB); 

for (size_t i = 0; i < numRecs; i++) {
    examDB[i] = malloc(sizeof ** examDB);
}

for (size_t i = 0; i < numRecs; i++) {
    free(&examDB[i]);
}
free(examDB);

BTW, this must be one of the most confusing malloc invocations I've ever seen:

malloc(numRecs * sizeof * examDB)

edited Oct 1, 2016 at 22:54

answered Oct 1, 2016 at 22:46

krzaq

16.5k4 gold badges50 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

LionHeart Over a year ago

This line examDB = malloc(numRecs * sizeof * examDB); is confusing. You meant examDB = malloc(numRecs * sizeof (*examDB) ); . Right ?

krzaq Over a year ago

Yes, but it's taken from the question as-is.

Iatropoulos George Over a year ago

Guys look here: stackoverflow.com/questions/605845/…

Jack · Accepted Answer · 2016-10-01 22:46:50Z

2

You need a free for each malloc. How many mallocs you have? 1, so how many free you need? Just 1.

You are allocating an array of 100 * sizeof(examDB) elements, which is dynamic but each element is a examDB, not a pointer to an examDB so you just need to free the whole array.

You would have required to free each element of the array if you had something like

// 1 malloc
examDB** array = malloc(sizeof(examDB*) * 100);

// 100 malloc
for (int i = 0; i < 100; ++i)
  examDB[i] = malloc(sizeof(examDB));

...

// 100 free
for (int i = 0; i < 100; ++i)
  free(examDB[i]);

// 1 free
free(examDB);

answered Oct 1, 2016 at 22:46

Jack

134k33 gold badges252 silver badges349 bronze badges

Comments

zondo · Accepted Answer · 2016-10-01 23:04:22Z

2

You allocated an array of objects. You can't free them by elements. What you can do is just free examDB itself:

 free(examDB);

The reason to do this is, as I said before, you are allocating a whole array of null values, as this code you posted states:

examDB = malloc(numRecs * sizeof * examDB);

What you can do to free element by element is to initialize your allocated elements like this:

for (int i = 0; i < 100; ++i)
  examDB[i] = malloc(sizeof(examDB));

Here is a C++ reference for malloc.

Tip: I have never seen this malloc invoked like this:

malloc(numRecs * sizeof * examDB);

It's more common to put it this way:

malloc(numRecs * sizeof(examDB));

edited Oct 1, 2016 at 23:04

zondo

20.4k8 gold badges50 silver badges89 bronze badges

answered Oct 1, 2016 at 22:47

amanuel2

4,6765 gold badges41 silver badges72 bronze badges

1 Comment

2501 Over a year ago

I agree, rhis 'style': malloc(numRecs * sizeof * examDB); is an abomination.

kfsone · Accepted Answer · 2016-10-01 22:48:22Z

0

examDB = malloc(numRecs * sizeof * examDB); //this allocates the needed memory

This expression allocates a single contiguous block of numRecs * sizeof *examDB, and sizeof *examDB is the same as sizeof struct exam. So at this point you can use examDB much in the same way as if it was declared struct exam examDB[numRecs].

Calls to free should be paired with calls to malloc and since you only malloc once, you only need to free once.

 examDB = malloc(numRecs * sizeof * examDB); //this allocates the needed memory
 //...
 free(examDB);

answered Oct 1, 2016 at 22:48

kfsone

24.4k3 gold badges46 silver badges78 bronze badges

Collectives™ on Stack Overflow

How to free a dynamically allocated array of structs in c?

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related