Label arrays not working c#

Question

I would like to use label arrays but it is not working i don't know what i am missing. Here is the code I am trying to get to work:

for (int x = 1; x <= 10; x++)
{
    Label[] label1 = new Label[10];  
    label1[x] = new Label();
    label1[x].AutoSize = true;
    label1[x].Text = "text";
    label1[x].Left +=10;
    label1[x].Top +=10;
}

In addition to Gilad Green's point, if you actually want these labels to appear in the UI somewhere, they have to be added to some control's Controls collection. — adv12
– adv12, Commented Oct 6, 2016 at 15:20
Also, you have an off by 1 error here in your loop. You have nothing in label[0] then label[10] doesn't exist. It appears Gilad's answer has addressed this. — KSib
– KSib, Commented Oct 6, 2016 at 15:23
@Tészta Sajtos - This time it was possible to understand the problem from the code but for next time please when you say "not working" specify what is going wrong: exception, unexpected behavior/output.... — Gilad Green
– Gilad Green, Commented Oct 6, 2016 at 16:03

Gilad Green · Accepted Answer · 2016-10-06 15:33:40Z

10

You are initializing a new Label1 array in each iteration so you will eventually have only the last one with 1 item at the last place.

Move the declaration of the label1 outside of the loop:

//Move this line outside of the loop's scope
Label[] label1 = new Label[10];

//Loop from 0 to the Length of the array instead of repeating 10 again
for (int x = 0; x < label1.Lenth; x++)
{   
    label1[x] = new Label();
    label1[x].AutoSize = true;
    label1[x].Text = "text";
    label1[x].Left +=10;
    label1[x].Top +=10;
}

I'd recommend that you look in MSDN about using arrays:

edited Oct 6, 2016 at 15:33

answered Oct 6, 2016 at 15:18

Gilad Green

37.3k7 gold badges67 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dmitrii Bychenko · Accepted Answer · 2016-10-06 15:22:40Z

4

In order to avoid such errors (wrong filling out), try generating arrays:

int n = 10;

Label[] label1 = Enumerable
  .Range(0, n)
  .Select(x => new Label() {
     AutoSize = true,
     Text = "text",
     Left = x * 10,
     Top = x * 10, 
   })
  .ToArray();

answered Oct 6, 2016 at 15:22

Dmitrii Bychenko

188k20 gold badges178 silver badges231 bronze badges

3 Comments

Gilad Green Over a year ago

I do like linq and it is a great tool but I think that for this case for this level this solution is an overkill.. It is quite basic array handling knowledge

KSib Over a year ago

Seems like a fine enough answer, but it certainly is a bit much for a presumed beginner.

Dmitrii Bychenko Over a year ago

This kind of solution (generating) allows to forget about array creation, index range; e.g. code in the question uses 10 as a magic number in (for.. x <= 10...) and in array creation new Label[10]; wrong indexing (1-based instead of zero based) etc.

Collectives™ on Stack Overflow

Label arrays not working c#

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related