Input string was not in a correct format error not getting resolved

Question

I am trying to get the String value in a list but getting error as

Input string was not in a correct format.

There are many helpful links available on the net but didn't resolved mine one.

Here is my code.

newRow["EXP_TYPE_ID"] = Convert.ToString(e.Record["EXP_TYPE"]);
    newRow["EXP_TYPE"] = CF.ExecuteScaler("Select Type_desc from type_mst where Type_Code = 'PAR' and Type_Abbr ='" + Convert.ToString(e.Record["EXP_TYPE"]) + "'").ToString();

and CF.ExecuteScaler

public string ExecuteScaler(string StrQuery)
{
    DB.EConnection();
    cmd = new OracleCommand(StrQuery, DB.conn);
    cmd.Connection = DB.conn;
    int val=Convert.ToInt32(cmd.ExecuteScalar());
    DB.conn.Close();
    string ret = val.ToString();
    return ret;
}

Note I can't change Scaler function.

update

StrQuery = Select Type_desc from type_mst where Type_Code = 'PAR' and Type_Abbr ='PUR'

and the value of the query

PURCHASER

Could you please show us the value of StrQuery when you pass it to ExecuteScaler()? — Roman Marusyk
– Roman Marusyk, Commented Oct 7, 2016 at 6:26
what type is Type_desc from the query? if it's string, what are the possible values? it looks like it's not convertible to int and that's why it's throwing the exception — slawekwin
– slawekwin, Commented Oct 7, 2016 at 6:44

slawekwin · Accepted Answer · 2016-10-07 06:54:48Z

1

I believe the exception is thrown in the following line?

int val=Convert.ToInt32(cmd.ExecuteScalar());

As you have said, cmd.ExecuteScalar() returns value "PURCHASER", which then you are trying to convert into int. That is clearly not possible, and this is what the exception is saying.

Please try it like that:

public string ExecuteScaler(string StrQuery)
{
    DB.EConnection();
    cmd = new OracleCommand(StrQuery, DB.conn);
    cmd.Connection = DB.conn;
    string ret = Convert.ToString(cmd.ExecuteScalar());
    DB.conn.Close();
    return ret;
}

edited Oct 7, 2016 at 6:54

answered Oct 7, 2016 at 6:49

slawekwin

6,3101 gold badge46 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

HEEN Over a year ago

getting error as cannot implicitly convert type int to string at line Convert.ToInt32(cmd.ExecuteScalar());

Roman Marusyk Over a year ago

@nad But you said before: Note I can't change Scaler function.

HEEN Over a year ago

@MegaTron: I added one more function and renamed it. I said,I cant change the function, but I can add function

Collectives™ on Stack Overflow

Input string was not in a correct format error not getting resolved

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related