PHP: trying to put href HTML attribute into a `echo`

Question

I can't seem to get a URL into echo. I want to make a link to open Google Maps:

I can't figure out what's wrong with my code:

$query = mysql_query("SELECT * FROM cev")or die(mysql_error());
while($row = mysql_fetch_array($query))
{
  $name = $row['sitecode'];
  $lat = $row['latitude'];
  $lon = $row['longitude'];
  $type = $row['sitetype']; 
  $city = $row['city']; 
  $id = $row['id'];

  echo("addMarker($lat, $lon,'<b>$name</b><a href="editcev.php?id=' . $row['id'] . '">View</a><br><br/>$type<br/>$city');\n");

Ruslan Osmanov · Accepted Answer · 2016-10-09 07:59:44Z

2

You have to fix the quotes:

 echo "addMarker($lat, $lon,'<b>$name</b><a href=\"editcev.php?id={$row['id']}\">View</a><br><br/>$type<br/>$city');\n";

Alternative ways

Here document

echo <<<EOS
addMarker($lat, $lon, '<b>$name</b><a href="editcev.php?id={$row['id']}">View</a><br><br/>$type<br/>$city');

EOS;

Concatenation

echo "addMarker($lat, $lon, '<b>$name</b>" .
  "<a href=\"editcev.php?id={$row['id']}\">View</a>" .
  "<br><br/>$type<br/>$city)";

Using addshashes

The addMarker looks like a JavaScript function. You might pre-process the HTML string by means of addslashes:

$html = <<<EOS
<b>$name</b><a href="editcev.php?id={$row['id']}">View</a><br><br/>$type<br/>$city
EOS;
$html = addslashes($html);

echo "addMarker($lat, $lon, '$html');\n";

Recommendations

I recommend using an editor with support of syntax highlighting.

Read about PHP strings. Especially the matter of escaping.

Finally, I wouldn't recommend writing any HTML/JavaScript within a PHP code. Use template engines such as Smarty or Twig instead.

edited Oct 9, 2016 at 7:59

answered Oct 9, 2016 at 7:32

Ruslan Osmanov

21.8k8 gold badges52 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ArtisticPhoenix Over a year ago

for 2 answers, you could use heredocs/newdocs for this. php.net/manual/en/language.types.string.php

Raja Raman TechWorld · Accepted Answer · 2016-10-09 07:42:00Z

0

It seems like you are trying to use method inside the echo statement. If you want to use methods, variables or some php stuffs you should not use quotes at most case unless it is an eval featured object or method.

Try like this

echo addmarker($lat, $lon, 
               '<b>'.$name.'</b> <a href="'.editcev.php?id=.' '.$row['id'].
               ".'>View</a><br><br/>'
               .$type.
               '<br/>'
               .$city.');'."\n");

I don't know your exact situation but i think this works

answered Oct 9, 2016 at 7:42

Raja Raman TechWorld

453 silver badges10 bronze badges

Comments

Umakant Mane · Accepted Answer · 2016-10-09 07:48:55Z

-1

  echo("addMarker(".$lat.",".$lon.",<b>".$name."</b><a href=ditcev.php?id=" . $row['id'] . ">View</a><br><br/>".$type."<br/>".$city.");\n");

answered Oct 9, 2016 at 7:48

Umakant Mane

1,0211 gold badge8 silver badges9 bronze badges

Collectives™ on Stack Overflow

PHP: trying to put href HTML attribute into a `echo`

3 Answers 3

Alternative ways

Recommendations

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Alternative ways

Recommendations

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related