Using value from another table in insert

Question

I have really annoying problem. I have this query that I am sending from c# project. Problem is that I cannot succeed to use value from another table into my insert. Here is my sample of code:

INSERT Izdavanje (registracioniBrojKorisnika, imeKorisnika, identifikacioniBrojKnjige, vremeidatumIzdavanja) 
  VALUES (@rbKorisnika, 
         (SELECT imeKorisnika 
            FROM Korisnici 
           WHERE registracioniBrojKorisnika=@rbKorisnika),
          @idKnjige, 
         GetDate());

INSERT INTO t (c1, c2, ...) SELECT... Where you can select columns and literals etc (i.e. expressions.) — jarlh
– jarlh, Commented Oct 10, 2016 at 12:44
@jarlh But I wanna pull just 1 or 2 values from another table, not all of them. — someRandomSerbianGuy
– someRandomSerbianGuy, Commented Oct 10, 2016 at 12:46
@jarlh I wanna do insert with 2 values that are from c# (I can do that without problem, of course) and 2 column values from row that have specific ID. — someRandomSerbianGuy
– someRandomSerbianGuy, Commented Oct 10, 2016 at 12:50
Put those values in the SELECT, i.e. SELECT @rbKorisnika, imeKorisnika, @idKnjige... — jarlh
– jarlh, Commented Oct 10, 2016 at 12:52

Twinkles · Accepted Answer · 2016-10-10 12:56:04Z

2

Just drop the VALUES clause:

INSERT INTO Izdavanje (registracioniBrojKorisnika, imeKorisnika, identifikacioniBrojKnjige, vremeidatumIzdavanja) 
  SELECT @rbKorisnika, imeKorisnika, @idKnjige, GetDate()
  FROM Korisnici 
  WHERE registracioniBrojKorisnika=@rbKorisnika

answered Oct 10, 2016 at 12:56

Twinkles

1,9941 gold badge17 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

someRandomSerbianGuy Over a year ago

Thanks! It's working! You cannot believe how much trouble I had with this piece of code! My brain sometimes suck so badly. Gracias!

someRandomSerbianGuy Over a year ago

Sorry, one more question. What is correct syntax if I wanna pull 2 values, not 1?

Twinkles Over a year ago

Just add the appropriate column name in the list.

Ganesh UP · Accepted Answer · 2016-10-10 13:02:56Z

0

May be, following query works perfectly for your issue. Just place proper datatype for @imeKorisnika variable.

DECLARE @imeKorisnika VARCHAR(50)
SELECT @imeKorisnika = imeKorisnika  FROM Korisnici  WHERE registracioniBrojKorisnika=@rbKorisnika

INSERT INTO Izdavanje (registracioniBrojKorisnika, imeKorisnika, identifikacioniBrojKnjige, vremeidatumIzdavanja) 
SELECT @rbKorisnika, @imeKorisnika, @idKnjige, GetDate()

answered Oct 10, 2016 at 13:02

Ganesh UP

1076 silver badges20 bronze badges

1 Comment

someRandomSerbianGuy Over a year ago

I actually had that idea and I tried that but I couldn't make it work, I probably messed up something in my attempt! Thanks! :)

Collectives™ on Stack Overflow

Using value from another table in insert

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related