Formatting loop for strings

Question

I'm having trouble formatting the strings below. Trying to keep the message centered with the borders, but having a hard time executing it. Below is what output I want and below that is my code I have so far. Note: I need to have a space on the left and right columns of the longest line and I need to utilize the split() func.

+---------------+
|     STOP!     |
| DANGER AHEAD  |
| Drive Safely! |
+---------------+

def border_sign(note):
    letter_count = 0
    for i in note:
        letter_count += 1
        return "+-------+\n| {} |\n+-------+\n".format(note)
 border_sign("STOP\nDANGER AHEAD\nDrive safely!")

Is this how the code is set up exactly in your editor? Because you are returning inside your loop. — idjaw
– idjaw, Commented Oct 10, 2016 at 22:18
And you're formatting the entire note, and using a counter that doesn't do anything, and not doing anything with i... — TigerhawkT3
– TigerhawkT3, Commented Oct 10, 2016 at 22:22
Why are you using a loop? In your example, you never make use of it. — Chris
– Chris, Commented Oct 10, 2016 at 22:22
I assumed I needed to count the largest string and then add a space for the column, but realized it was wrong. — Alan Wakke
– Alan Wakke, Commented Oct 10, 2016 at 22:34

TigerhawkT3 · Accepted Answer · 2016-10-10 22:43:38Z

2

Split the string into separate lines, then center each line. Remember to either print each line immediately within the function, build up a list, or yield each line rather than returning after the first line. You can also determine and use a calculated width rather than a static value.

def border_sign(note):
    note = note.splitlines()
    m = len(max(note, key=len))
    yield ('-'*m).join('++')
    for line in note:
        yield ("|{:^%d}|" % m).format(line)
    yield ('-'*m).join('++')

print(*border_sign("STOP\nDANGER AHEAD\nDrive safely!"), sep='\n')

edited Oct 10, 2016 at 22:43

answered Oct 10, 2016 at 22:25

TigerhawkT3

49.4k6 gold badges66 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alan Wakke Over a year ago

Thanks for the explanation on the split. If I was using other test functions, how would I go about yielding the correct amount of '+'s and '-'s?

TigerhawkT3 Over a year ago

@AlanWakke - See the edit. The +s don't change (it's simply one in each corner), but you can calculate the necessary space and - characters based on the maximum width.

Iłya Bursov · Accepted Answer · 2016-10-10 22:29:01Z

1

Quick sample to consider, not production ready code:

def border_sign(note):
    rows = note.splitlines()
    mlen = len(max(rows, key=len))
    print "+" + "-" * (2+mlen) + "+"
    for row in rows:
        print ("| {:^"+str(mlen)+"} |").format(row)
    print "+" + "-" * (2+mlen) + "+"

answered Oct 10, 2016 at 22:29

Iłya Bursov

24.4k4 gold badges36 silver badges68 bronze badges

Comments

eyquem · Accepted Answer · 2016-10-11 01:03:44Z

0

def border_sign(x):
    splitted = x.splitlines()
    M = max(map(len,splitted))
    horiz = '+-%s-+' % (M*'-')
    patiz = '| {0: ^%d} |' %  M
    print(horiz,*map(patiz.format,splitted), horiz, sep='\n')

border_sign("STOP\nDANGER AHEAD\nDrive safely!")

patiz.format is a function, then can be used in map

answered Oct 11, 2016 at 1:03

eyquem

27.8k7 gold badges43 silver badges46 bronze badges

Collectives™ on Stack Overflow

Formatting loop for strings

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related