For Loop with return won't exit

Question

I have two arrays:

Matches

var matches = [
{ playerId: 1, matchId: 1 },

{ playerId: 2, matchId: 1  },

{ playerId: 3, matchId: 2 }];

Players

var players= [
{ name: "Ronaldo", id: 1 },
{ name: "Messi", id: 2 },
{ name: "Zlatan" id: 3 }];

I want to list all players who played on match with matchId 1;

for (i = 0; i < matches.length; i++) {

    if (matches[i].matchId == 1)
    {
        var p = matches[i].playerId;
        //alert(p);
        var currentName = getPlayersInfo(p);
        alert(currentName);

    }
}

function getPlayersInfo(id){
  var curID = id;
  var name;
  for (i = 0; i < players.length; i++) {

    if (players[i].id == curID) {
       name = players[i].name;
    }
  }

       return name;
}

If I have just alert(p); instead of that I call getPlayersInfo(p) than I am getting alert two times with id 1 and 2 and that works fine but with getPlayersInfo(p) first alert is Ronaldo and than I am getting alert Messi multiply times.

What I am doing wrong in getPlayersInfo() ?

What is players? Where is that defined?

Phil
– Phil

2016-10-19 22:02:36 +00:00
Commented Oct 19, 2016 at 22:02 — Phil
– Phil, Commented Oct 19, 2016 at 22:02
@Phil I edited now

Del boy
– Del boy

2016-10-19 22:15:39 +00:00
Commented Oct 19, 2016 at 22:15 — Del boy
– Del boy, Commented Oct 19, 2016 at 22:15

Phil · Accepted Answer · 2016-10-19 22:11:44Z

4

You are overwriting the same i variable (which is global) because you aren't declaring it with var. In your for loops, use

for (var i = 0; ...

Another solution would be

for (var i = 0, l = matches.length; i < l; i++) {
    var match = matches[i];
    if (match.matchId === 1) {
        var name = players.find(function(player) {
            return player.id === match.playerId;
        });
        alert(name); // note, could be "undefined"
    }
}

If you have to look players up by their ID regularly, consider creating a map (ES2015 syntax for brevity)

let playersById = players.reduce((map, player) => {
    map[player.id] = player;
    return map;
}, Object.create(null));

then you can simply reference

playersById[match.playerId];

edited Oct 19, 2016 at 22:11

answered Oct 19, 2016 at 22:04

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

For Loop with return won't exit

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related