Bluebird throwing exception at source code

Question

I am using bluebirdjs for nodejs application. It throws an exception from its source code.

Line : try {throw new Error(); } catch (e) {ret.lastLineError = e;}

Path : bluebird/js/release/util.js

Line : 374

This exception seems unnecessary to me. It only throws exception. Is it rational to delete this line?

Same code also exists inside async.js at line 3.

The catch block has a side effect so you can't delete it without reasonably expecting some functionality to change. — joews
– joews, Commented Oct 20, 2016 at 11:33
But try block will always throw exception. It is someting like if(true){}. It should be like "ret.lastLineError = new Error();". But this method is looking like a bug or forgotten when publishing. — osmanraifgunes
– osmanraifgunes, Commented Oct 20, 2016 at 11:40

Esailija · Accepted Answer · 2016-10-20 12:35:18Z

4

In IE an Error object will not have a .stack property unless it goes a through try catch. The .stack property is needed to see which line and file the code is in.

ret.lastLineError = new Error() would therefore only work in firefox and chrome

answered Oct 20, 2016 at 12:35

Esailija

140k24 gold badges280 silver badges328 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bergi Over a year ago

So it will also get the stack from the throw and not the new Error, wouldn't it?

Collectives™ on Stack Overflow

Bluebird throwing exception at source code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related