Fill string array with url links through for loop

Question

I need a little help.

I have a string array (urllinks) which I want to fill with url links which are being parsed with jsoup through a for loop.

In below code example there are 2 urls but the list only gets filled with the first link. I don`t know how many links will be parsed, can be 1 but also 12.

public static String[] urllinks;

...

for (int i = 0; i < links.size(); i++) {    // links size = 2  
    String url = doc.select("a").attr("abs:href");
    urllinks[i] = url;

}

Any help would be appreciated.

Thanks in advance.

String url will give you the same result everytime because you don't change anything. also, you should use ArrayList because you said that you don't know how many links will be parsed and array is for constant size of links. — T.S
– T.S, Commented Oct 24, 2016 at 17:12
what do you think this doc.select("a").attr("abs:href"); does, and why would you expect to successive calls to yield different results? — njzk2
– njzk2, Commented Oct 24, 2016 at 18:39

Nicolas Filotto · Accepted Answer · 2016-10-24 18:37:32Z

3

You problem is due to the fact that you call attr("abs:href") on doc.select("a") which returns an object of type Elements such that you always get the first match as stated in the javadoc:

Get an attribute value from the first matched element that has the attribute.

You should rather iterate as next:

List<String> urls = new ArrayList<>();
// Iterate over all the links that have an attribute abs:href
for (Element link : doc.select("a[abs:href]")) {
    urls.add(link.attr("abs:href"));
}
urllinks = urls.toArray(new String[urls.size()]);

edited Oct 24, 2016 at 18:37

answered Oct 24, 2016 at 17:20

Nicolas Filotto

45.3k11 gold badges97 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Simon Over a year ago

First of all thx Nicolas for the answer but I get a ArrayIndexOutOfBoundsException on urllinks[i]. (length=1; index=1

Simon Over a year ago

No problem, take your time ;)

Simon Over a year ago

Unfortunatly same Exception.

Nicolas Filotto Over a year ago

it means that urllinks doesn't have the right length, it should be 2 not 1

Nicolas Filotto Over a year ago

I provided another approach based on a list please check again

Simon · Accepted Answer · 2016-10-24 19:34:46Z

0

To answer my own question, I solved it by creating an arraylist and then convert it back to a string array. Dirty but it works.

{
  private static String[] urllinks;
  private static ArrayList<String> mStringList = new ArrayList<>();
  ...

  int i = 0;
  for (Element el : links) {
       String url = el.attr("abs:href");
       if (url != null) {
                mStringList.add(i, url);
                i++;
            } 
       else {
          // Do something
       }

  urllinks = mStringList.toArray(urllinks);
  // check if urls are actualy in string array
  Log.d("LINK 1", urllinks[0]);
  Log.d("LINK 2", urllinks[1]);
...
}

edited Oct 24, 2016 at 19:34

answered Oct 24, 2016 at 18:35

Simon

1,7312 gold badges14 silver badges29 bronze badges

2 Comments

Nicolas Filotto Over a year ago

i is useless in this case, if you don't filter the links first as I did you will get empty String in case you have links without the attribute abs:href

Simon Over a year ago

It works like expected Nicolas, I check on empty urls also. Changed code.

Collectives™ on Stack Overflow

Fill string array with url links through for loop

2 Answers 2

5 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related