Compiler Error: No matching function for call to find

Question

I was trying to use vectors as I just started studying but was stuck on this error. I tried to look cpp reference and wrote as on it but still getting error.

 #include<vector>
 #include<iostream>
 #include<cstring>
 using namespace std;
 int main()
{

vector<string> vec;

vec.push_back("First");

vec.push_back("second");

for( int i = 0; i < 4 ; i++ )
    vec.push_back("RepeatTimes");

vector<string>::iterator fp = find(vec.begin(), vec.end(), "First");


for( vector<string>::iterator it = vec.begin(); it != vec.end(); it++ )                  cout<<*it<<" ";

}

Error is :

[Error] no matching function for call to 'find(std::vector<std::basic_string<char> >::iterator, std::vector<std::basic_string<char> >::iterator, const char [6])'

You're missing a #include <string>. Also, get rid of using namespace std;. — Sam Varshavchik
– Sam Varshavchik, Commented Oct 25, 2016 at 2:08
@SamVarshavchik is right. Please stop using using namespace std; — amanuel2
– amanuel2, Commented Oct 25, 2016 at 2:09
You need to include <algorithm> It's saying it can't find the function; not that it can't find the string. You most likely got std::string indirectly from <iostream>. — Trevor Hickey
– Trevor Hickey, Commented Oct 25, 2016 at 2:10
using namespace std rocks. This isn't in a header - there's no reason to avoid it here. Unless you just like typing std:: for the hell of it. Also, for(auto it = vec.begin();...) — 3Dave
– 3Dave, Commented Oct 25, 2016 at 2:12
so <cstring> is not same as <string>? and why stop using std namespace ? — Anmol
– Anmol, Commented Oct 25, 2016 at 2:14

Toby Speight · Accepted Answer · 2016-10-25 14:51:19Z

11

You forgot to include the <algorithm> header where std::find lives.

You should also include <string> for access to std::string.
You most likely included <string> indirectly from another header and should not rely on it.

Since you are learning, I'll go further to suggest modern alternatives to your code.

Instead of pushing elements back one at a time,

std::vector<std::string> vec;
vec.push_back("First");
vec.push_back("second");

you can use initialization lists:

std::vector<std::string> vec {"First", "Second"};

Instead of using a for loop to repeatedly add the same element,

for( int i = 0; i < 4 ; i++ )
    vec.push_back("RepeatTimes");

you can use the insert method:

vec.insert(vec.end(), 4, "RepeatTimes");

Consider deducing type names when they are verbose and aren't adding any readability value to the code:
```
auto fp = std::find(vec.begin(), vec.end(), "First");
```
Use range-based for loops when iterating over the entire range of the container:
```
for (auto it: vec){
    std::cout << it << " ";
}
```

edited Oct 25, 2016 at 14:51

Toby Speight

32.4k58 gold badges83 silver badges118 bronze badges

answered Oct 25, 2016 at 2:24

Trevor Hickey

38.4k37 gold badges180 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

khôi nguyễn Over a year ago

4. An alternative is using std::for_each with lamda function :)

Scott · Accepted Answer · 2020-05-22 08:20:29Z

4

Adding:

#include <algorithm>

solved my problem

answered May 22, 2020 at 8:20

Scott

5,9468 gold badges48 silver badges79 bronze badges

Collectives™ on Stack Overflow

Compiler Error: No matching function for call to find

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related