How to modify response (get) function in angular services?

Question

I want to move this function to services.js:

News.all().async().then(function(data) {
  $scope.news = data['data']['NewsList'];
});

And than call it in controller.js by this command:

$scope.news = News.all();

I try many ways, but them did not work.

Here is my services.js:

.factory('News', function($http) {
  function returnNews() {
    return {
      async: function() {
        return $http.get('test.json');
      }
    };
  }
  return {
    all: function() {
      return returnNews();
    }
  }
});

Marius · Accepted Answer · 2016-10-25 20:29:19Z

1

Well if you call News.all() in the end you will get an object with an async property: {async} and I don't think this is what you want. What you can do is pass a callback to the service:

.factory('News', function($http) {
  return {
    all: function(callback) {
      return $http.get('test.json').then(callback);
    }
  }
});

and in the controller you have to do:

News.all(function(data){
  $scope.news = data
});

answered Oct 25, 2016 at 20:29

Marius

3,7435 gold badges27 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

William B Over a year ago

This seems like an anti-pattern. Instead of converting a promise into a traditional callback-style async operation, just expose the promise and chain to it. News.all().then(function (data) ... and have News.all return $http.get('test.json')

Marius Over a year ago

Yes, or you can do as @WilliamB sugested

Collectives™ on Stack Overflow

How to modify response (get) function in angular services?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related