Getting an NSString out of an NSArray

Question

I am trying to save and read back some application settings stored as NSStrings in an iPhone app and have been having some trouble.

The code to save looks like:

    NSMutableArray *array = [[NSMutableArray alloc] init];
   [array addObject:accountID];
    ...
   [array writeToFile:[self dataFilePath] atomically:YES];
   [array release];

And the code to read looks like (accountID is an NSString*):

    NSArray *array = [[NSArray alloc] initWithContentsOfFile:filePath];         
    accountID = [array objectAtIndex:0];
    ...                     
    [array release];
    NSLog(@"Loading settings for: %@", accountID);

The read code throws an exception because after the array is released the accountID variable also appears to have been released (moving the NSLog call before releasing the array works fine). So I'm guessing that I'm creating a reference to the array instead of pulling out the actual string contained in the array. I tried several things to create new strings using the array contents but haven't had any luck.

mmmmmm · Accepted Answer · 2010-10-26 15:56:36Z

2

You guess is on the right lines although you have a reference to the 0th element of the array not the array. The array consists of pointers to NSString objects. The Strings will get get released when yhe array is released.

You need to retain the element you are using e/g/

NSArray *array = [[NSArray alloc] initWithContentsOfFile:filePath];         
NSString* accountID = [[array objectAtIndex:0]retain];
...                     
[array release];
NSLog(@"Loading settings for: %@", accountID);

answered Oct 26, 2010 at 15:56

mmmmmm

32.8k28 gold badges92 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

willcodejavaforfood · Accepted Answer · 2010-10-26 15:55:56Z

2

When you release the array the reference to the accountID will also be released. You need to retain it.

accountID = [[array objectAtIndex:0] retain];

Then obviously at some point you need to release it.

answered Oct 26, 2010 at 15:55

willcodejavaforfood

44.2k17 gold badges83 silver badges111 bronze badges

Comments

Sam Dufel · Accepted Answer · 2010-10-26 15:54:20Z

1

try [accountID retain] before you release the array

answered Oct 26, 2010 at 15:54

Sam Dufel

17.6k3 gold badges51 silver badges52 bronze badges

Collectives™ on Stack Overflow

Getting an NSString out of an NSArray

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related