PHP MYSQL Table only display one row of results

Question

I have a page where I am using a parameter in the URL as a filter for my SQL query. I created a variable from the URL parameter:

$station = htmlspecialchars($_GET["station"]);

Then set up a conditional query depending on whether or not the URL parameter is set:

if(isset($_GET['station'])) {
    $query = "SELECT * FROM song_of_the_day WHERE station = '$station'";
}
else {
    $query = "SELECT * FROM song_of_the_day WHERE end_date >= CURDATE()";
}
    $result = mysql_query($query) or die(mysql_error());
    $num_rows = mysql_fetch_row($result);

Then I display the results in a table:

echo "<table width='758' border='0' cellpadding='10' cellspacing='0' class='myTable'>";
while($row = mysql_fetch_array( $result )) {
echo '<tr>';
echo '<td align="left" width="48">' . $row['station'] . '</td>';
echo '<td align="left">' . date('M j, Y',strtotime($row['end_date'])) . '</td>';
echo '<td width="24" align="left"><a href="edit.php?id=' . $row['id'] . '"><img src="http://yourligas.yourli.com/ad-inventory/edit.png" border="0"></a></td>';
echo '<td width="24" align="left"><a href="delete.php?id=' . $row['id'] . '" data-confirm="Are you sure you want to delete this entry?" ><img src="http://yourligas.yourli.com/ad-inventory/remove.png" border="0"></a></td>';
echo "</tr>"; 
echo '</tbody>';
    } 
echo "</table>";

The query works find when the ELSE command uses the query, where I'm not relying on the parameter in my SQL, but the problem I am seeing when the URL parameter ISSET is only one row gets displayed from the query when there is more than one row that matches the criteria in the actual database. Does anybody know why this is happening?

Thank you

Please stop using mysql_* functions. These extensions have been removed in PHP 7. Learn about prepared statements for PDO and MySQLi and consider using PDO, it's really pretty easy. — Jay Blanchard
– Jay Blanchard, Commented Oct 26, 2016 at 19:03
Little Bobby says your script is at risk for SQL Injection Attacks.. Even escaping the string is not safe! — Jay Blanchard
– Jay Blanchard, Commented Oct 26, 2016 at 19:03
Stackoverflow on MySQL. (1) Ask question (2) Have it ignored and instead be told about PDO. — Luke
– Luke, Commented Oct 26, 2016 at 19:07
Which is a perfectly valid response. mysql_ have been deprecated for over a decade now. Using it is a security hazard, and usually involves horribly insecure code. — junkfoodjunkie
– junkfoodjunkie, Commented Oct 26, 2016 at 19:08

Sam Dufel · Accepted Answer · 2016-10-26 19:11:32Z

-1

In this line, you appear to be consuming the first row of data while attempting to get the number of rows found:

$num_rows = mysql_fetch_row($result);

This removes the first row from your result cursor.

Instead, you probably meant to do the following:

$num_rows = mysql_num_rows($result);

answered Oct 26, 2016 at 19:11

Sam Dufel

17.6k3 gold badges51 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP MYSQL Table only display one row of results

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related