Rails 4 - Moving js inline script inside View to JS file

Question

I would like to move some js inline scripts I have on my homepage to a javascript file (in Assets) but there is some complexity due to variables.

home.html.erb

<div>
this is the homepage
</div>
<script>
  <% @deal.deal_details.each_with_index do |popin, index| %>
  <% index_plus_one = index + 1 %> 
    function loadInfoPopin() {
      var msg;
      msg = Messenger().post({
        message:  '<%= j render partial: "deals/info_popin/info_popin#{ popin['popin_id'] }",
                  locals: { popin: popin, index: index_plus_one } %>'
      });
    } 
  <% end %>
</script>

For the sake of information here is the format of the Deal's column/attribute 'deal_details' (it's a json attribute):

[{"popin_id":"4","text1":"qqq","text2":"sqsq","image1":"sqqs"},{"popin_id":"5","text1":"sqqs","video1":"s"}]

This is an example and you can have as many json block inside the array as possible.

deals/info_popin/info_popin5.html.erb (it's an example)

<div>
       <p><a href="<%= popin['image1'] %>">cool image</a></p>
    </div>
</div>

Now, how can I move the whole script or at least the function loadInfoPopin() to a javascript file (that is to say away from the view home.html.erb) ?

Thanks

Andrew · Accepted Answer · 2016-10-27 14:01:05Z

1

How about moving the loadInfoPopin() function into a separate JS file and altering the function slightly to take in an argument for the html message?

function loadInfoPopin(html_message) {
  Messenger().post({
    message:  html_message
  });

Setup the html for the message within the loop before passing into and calling loadInfoPopin.

answered Oct 27, 2016 at 14:01

Andrew

1,7871 gold badge10 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andrievs Niedra · Accepted Answer · 2016-10-26 22:54:28Z

0

.js.erb is an option. This way the js files will be parsed before compiling. Not sure though it will work the way you want.

I would recommend to leave the variables in the layout as vars and moving only the static JS parts to the assets.

answered Oct 26, 2016 at 22:54

Andrievs Niedra

263 bronze badges

1 Comment

Mathieu Over a year ago

I alreayd tried with gon gem and using a .js.erb file but it does not work. I 'd need more precise code suggestion.

Collectives™ on Stack Overflow

Rails 4 - Moving js inline script inside View to JS file

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related