Error using react-update

Question

My store:

{
    people: [
        {
            id: 12345,
            name: Person 1
        },
        {
            id: 54321,
            name: Person 2
        }
    ]
}

I'm trying to update the name property on Person 1. I'm using react-addons-update like this:

update(state, {
    people: {
        [action.person.id]: {
            name: action.person.name
        }
    }
}

Where action.person is an object { id: 12345, name: New name }.

However, I keep getting an error:

Uncaught (in promise) TypeError: Cannot read property 'name' of undefined(…)

This is being thrown in react-addons-update's update method. Specifically,

for (var k in spec) {
    if (!(ALL_COMMANDS_SET.hasOwnProperty(k) && ALL_COMMANDS_SET[k])) {
        nextValue[k] = update(value[k], spec[k]);    // Error occurs here
    }
}

As far as I can tell the problem is that when nextValue, value and spec are all set to people, k is set to action.person.id. And of course that id doesn't exist in the array (it's an array of people).

So my question is, what can I pass in instead of [action.person.id] to do this? According to both this and this what I have should be working.

ps you should be using immutability-helper – react-addons-update is deprecated — Mulan
– Mulan, Commented Oct 28, 2016 at 16:20

FlatLander · Accepted Answer · 2016-10-28 15:15:01Z

2

here you go

update(state, {
    people: {
        $apply: (people) => people.map((person) => {
            if(person.id !== action.person.id) {
                return person;
            }

            return {
                ...person,
                name: action.person.name
            }
        })
    }
}

answered Oct 28, 2016 at 15:15

FlatLander

1,78515 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Error using react-update

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related