Dynamic UITableViewCell height not working

Question

(iOS 8 with Storyboard) I have a right detail UITableViewCell on my tableView.

In storyboard the Title and Right Detail labels are set to numberoflines = 0

My Code:

- (void)viewDidLoad {
    [super viewDidLoad];
    keyArray = [[NSMutableArray alloc]init];
    self.table.estimatedRowHeight = 140.0;
    self.table.rowHeight = UITableViewAutomaticDimension;
    [spinner startAnimating];
    [self cleanJson:prunedDictionary];

}

- (CGFloat) tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath {
    return UITableViewAutomaticDimension;
}

- (CGFloat) tableView:(UITableView *)tableView estimatedHeightForRowAtIndexPath:(nonnull NSIndexPath *)indexPath{
    return UITableViewAutomaticDimension;

}

At the end of cleanJson I run [self.table reloadData]. The TableViewCell does resize but they all resize to the same size and it seems like the default size. (The reason I know they resize is because in Storyboard I set the height to 200 and they were all resized to a smaller size when the app ran)

Why aren't they resizing correctly?

Your constraints are likely wrong. Can you add them to your question somehow? — d.felber
– d.felber, Commented Oct 30, 2016 at 12:55
@d.felber No constraints since as I mentioned, its not a custom cell. Therefore it already has constraints as far as I know — huddie96
– huddie96, Commented Oct 30, 2016 at 12:56

matt · Accepted Answer · 2016-10-30 13:07:20Z

3

The problem is that you are using a built in cell type and the built in title and detail labels. Those cell types are not self sizing.

You must use a custom cell and design it yourself, with constraints that size the cell from the inside out.

answered Oct 30, 2016 at 13:07

matt

540k97 gold badges947 silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Earl Grey · Accepted Answer · 2016-10-30 12:59:54Z

0

You do not need any of those two delegate methods. The cells do not resize properly because your auto layout constraints setup is incorect.Check those constraints and make sure there exists at least one constraint-view path from top to bottom. By that I mean you are able to logically hop from top of the cell itself..via all the views and vertical constraitns between then down to the bottom.

like this:

top of superview

margin constraint

view

margin constraint

.

view

margin constraint

bottom of superview.

The views in the between must either be constrained to fixed size ..or they must abe able to resize according to their content. It's clear that the final height is a combination of all those margins and view heights.

It's a linear function

finalheight = topmargin + viewHeight + margin + viewHieght..etc....etc..bottommargin

answered Oct 30, 2016 at 12:59

Earl Grey

7,4666 gold badges41 silver badges62 bronze badges

4 Comments

huddie96 Over a year ago

It's not a custom cell. So constraints are already set I believe

Earl Grey Over a year ago

Can you verify it's really true? Assumptions are the single worst enemy in debugging.

huddie96 Over a year ago

That its not a custom cell? I can verify that yes. That custom cells do not require constraints. Almost positive.

Earl Grey Over a year ago

That the constraints are in place and working. Trust nobody, certainly not UIKit. You can use Live View Debugger.

d.felber · Accepted Answer · 2016-10-30 13:37:56Z

-1

There is actually a way - but I would prefer creating a custom UITableViewCell:

override func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
    let cell = self.tableView(tableView, cellForRowAt: indexPath)
    let targetSize = CGSize(width: self.tableView.bounds.width, height: CGFloat.infinity)

    return cell.systemLayoutSizeFitting(targetSize,
                                        withHorizontalFittingPriority: 1000,
                                        verticalFittingPriority: 900).height
}

answered Oct 30, 2016 at 13:37

d.felber

5,4781 gold badge23 silver badges36 bronze badges

1 Comment

えるまる Over a year ago

doesn't work now

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSLayoutConstraint constant is not finite!  That's illegal.  constant:inf

Collectives™ on Stack Overflow

Dynamic UITableViewCell height not working

3 Answers 3

Comments

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related