How to add promise.all in Node.js Sequelize findOrCreate in loop?

Question

I create two models in sequelize. I got array of results "Users" and than loop through to get or create new "Room" based on User.id. I want to print all rooms after all is done. I got empty array in console, because its asynchronious. How can I call console.log after creating all Rooms?

var Users = sequelize.import(__dirname + "/../models/own/user");
var Rooms = sequelize.import(__dirname + "/../models/own/room");    
var _this = this;

this.users = [];
this.rooms = [];

Users.findAll().then(function(users) {
    _this.users = users;

    users.forEach(function(user){

        Rooms.findOrCreate({where: {user_id: user.get('id')}})
        .spread(function(room, created) {
          _this.rooms.push(
            room.get({
              plain: true
            })
          );

        });

    });

    console.log(_this.rooms)

});

Yrysbek Tilekbekov · Accepted Answer · 2016-11-03 11:49:56Z

7

You can execute array of promises through Promise.all:

var promises = users.map(function(user){
    return Rooms.findOrCreate({where: {user_id: user.get('id')}});
});
Promise.all(promises).then(function(dbRooms){
    for(var key in dbRooms){
        _this.rooms.push(dbRooms[key][0].get({plain: true}));
    }
    console.log(_this.rooms);
});

edited Nov 3, 2016 at 11:49

answered Nov 3, 2016 at 11:32

Yrysbek Tilekbekov

2,86513 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Benjamin Gruenbaum Over a year ago

Prefer map to forEach in this case.

Benjamin Gruenbaum Over a year ago

With a lambda it's const rooms = Promise.all(users.map(user => Rooms.findOrCreate({where: {user_id: user.get('id')}}))); rooms.then(...)

leonard.javiniar · Accepted Answer · 2016-11-03 10:02:36Z

0

Try putting console.log in .then function. Chain it after .spread. I believe an array of the rooms will be passed as an argument to the first callback:

.then(function(rooms){
    ...
})

or,

you may try to refactor your code and put your logic in a .then function.

Rooms.findOrCreate({where: {user_id: user.get('id')}})
.then(function(rooms, created) {
    var room;

    for(var i in rooms){
        room = rooms[i];

        _this.rooms.push(
            room.get({
                plain: true
            })
        );
    }
});

answered Nov 3, 2016 at 10:02

leonard.javiniar

5558 silver badges27 bronze badges

1 Comment

RobM Over a year ago

The chain with then doesn't work. Then is executed every spread execution in a loop. I need sth executed once after all iteration of forEach

Collectives™ on Stack Overflow

How to add promise.all in Node.js Sequelize findOrCreate in loop?

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related