Passing an array to the method.

Question

I have written a simple code and have passed an array to the method and have returned the value and trying to get it printed. Somehow, I am not getting the required output. Please point out where I got wrong. Also tips to make the code concise are most welcome.

static void Main(string[] args)
    {
        string[] ar = new string[] { "hello", "world", "people" };

        writeString(ar);
        Console.WriteLine(ar);

        Console.ReadLine();

    }

    static string writeString(string[] ar)
    {
        string a1 = " ";
        foreach (string a in ar)
        {
            a1 = a1 + a;
        }
        return a1;
    }

@LPK - while completely correct, I think you misunderstood OP's intention - clearly writeString should write string - meaning it should be writing to console instead of returning result... — Alexei Levenkov
– Alexei Levenkov, Commented Nov 12, 2016 at 8:57
Do consider String.Join suggested by multiple answers, if you are trying to convert whole array into single string separated by a delimiter, though your question doesn't suggest that as a requirement. — Mrinal Kamboj
– Mrinal Kamboj, Commented Nov 12, 2016 at 9:15

adrian · Accepted Answer · 2016-11-12 09:01:39Z

4

I hope the code sample makes it clear. You have to capture the return value from the writeString function and output that.

static void Main(string[] args)
{
    string[] ar = new string[] { "hello", "world", "people" };

    string output = writeString(ar);
    Console.WriteLine(output);

    Console.ReadLine();

}

static string writeString(string[] ar)
{
    string a1 = " ";
    foreach (string a in ar)
    {
        a1 = a1 + a;
    }
    return a1;
}

answered Nov 12, 2016 at 9:01

adrian

2761 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Poomrokc The 3years Over a year ago

Additionally String.Join() can be used to replace the writeString() function with a few adjustments.

Mrinal Kamboj Over a year ago

@PoomrokcThe3years In original question OP is not replicating Join functionality, since Join will add limiter post all the elements of the collection, as it creates a single string, here empty space is only appended i nthe beginning, not between elements

Poomrokc The 3years Over a year ago

@MrinalKamboj What if I do output=" "+String.Join(String.Empty,ar); ? Would something like this work? I don't know i haven't code C# for like 3 years.

Mrinal Kamboj Over a year ago

@PoomrokcThe3years would certainly, in fact that's what he's trying to do in current method, however, my gut feeling is OP might actually need a Join, that you have showed earlier :)

adrian Over a year ago

@SaurabhCooks I'm glad. Could you accept it is the correct answer :-)

marc_s · Accepted Answer · 2021-05-20 13:26:25Z

2

You can refactor it as below with concise code without the need of another method.

Note: I have added space before the array items as you did. But if you need space between each items of array then change the delimiter line as string delimiter = " ";

You can change the delimiter below with any character like , etc.

static void Main(string[] args)
{
    string[] ar = new string[] { "hello", "world", "people" };

    string delimiter = "";
    string output = " " + String.Join(delimiter, ar);
    Console.WriteLine(output);
    // You can do the same in one line as below by commenting above three lines
    // Console.WriteLine(" " + String.Join("", ar));

    Console.ReadLine();

}

edited May 20, 2021 at 13:26

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered Nov 12, 2016 at 9:08

Aruna

12k3 gold badges31 silver badges42 bronze badges

10 Comments

Mrinal Kamboj Over a year ago

Original functionality doesn't do the work of Join, eve if that's the intention as it just adds the empty space in the beginning and no where else

Aruna Over a year ago

@MrinalKamboj Why not add the same here with " " + String.Join(delimitter, ar) ?

Aruna Over a year ago

I think, he needs space between the array items and doing wrongly. In that case delimitter becomes string delimitter = " ";

Mrinal Kamboj Over a year ago

That's your assumption of what OP needs, it is not specified anywhere, so I am not sure, what's the use case, he just asked about printing output, which was anyway wrong.

Aruna Over a year ago

Please read his question once again. He asks for Also tips to make the code concise are most welcome

|

Mrinal Kamboj · Accepted Answer · 2016-11-12 09:07:49Z

1

I have written a simple code and have passed an array to the method and have returned the value and trying to get it printed. Somehow, I am not getting the required output

As everyone has pointed that you are not receiving the returned value to print it or do anything with it, so a simple code modification is first receive the result / output:

var result =  writeString(ar);

What is your Result expectation

Since you are printing the array, instead of returned value. Array is not even modified in the called function anywhere, therefore it remains exactly same. Simplest way to achieve the expected result would be:

Console.WriteLine(writeString(ar));

answered Nov 12, 2016 at 9:07

Mrinal Kamboj

11.6k5 gold badges45 silver badges82 bronze badges

Comments

Farhan Nasim · Accepted Answer · 2016-11-12 09:29:49Z

1

You are not printing the string returned by the writeString(string[] ar) method. Instead you are printing the input string array variable ar (on line Console.WriteLine(ar)). That's your problem. That WriteLine statement prints only the fully qualified name of the variable ar's type: System.String[].

Change the line Console.WriteLine(ar) to Console.WriteLine(writeString(ar)) to get your desired output.

edited Nov 12, 2016 at 9:29

answered Nov 12, 2016 at 9:00

Farhan Nasim

8175 silver badges13 bronze badges

1 Comment

Mrinal Kamboj Over a year ago

Please add some code to make it a valid answer or better use comment section for a suggestion

Collectives™ on Stack Overflow

Passing an array to the method.

4 Answers 4

5 Comments

10 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

10 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related