Entity Framework - Loop then call SaveChanges

Question

Would SaveChanges save all changes of debt? Or only the last because it lost the reference because I change element debt in each loop?

List<DTO.ClientDebt> ClientDebtList = Business.Generic.GetAll<DTO.ClientDebt>();

foreach (var oClienteDeuda in oClienteDeudaSyncList) //oClienteDeudaSyncList is a list of debts
{
    DTO.ClientDebt debt = ClientDebtList.Where(x => x.ClienteId == oClienteDeuda.ClienteId && x.NumeroComprobante == oClienteDeuda.NumeroComprobante).FirstOrDefault();
    debt.Active = oClienteDeuda.Active ? 1 : 0;
}

Data.Generic.SaveChanges();

The code you provide will update all elements in ClientDebtList, you migth want to add a if null check before setting debt.Active =.... — Martin M
– Martin M, Commented Nov 16, 2016 at 13:24
Or atleast all touched elements will be updated in the database. — Martin M
– Martin M, Commented Nov 16, 2016 at 13:25

Sampath · Accepted Answer · 2016-11-16 14:10:24Z

4

The way you have done is the correct way when we're dealing with the foreach loops.You can do the same thing inside the loop too.But it'll degrade the performance of the operation heavily.So always do the SaveChanges() after the foreach loop.SaveChanges() method persist modifications made to all entities attached to it.So you don't need to worry about the reference changes and etc.It works as unit of work.That means either save all or none.

Note : SaveChanges() operates within a transaction. SaveChanges() will roll back that transaction and throw an exception if any of the dirty ObjectStateEntry objects cannot be persisted.

edited Nov 16, 2016 at 14:10

answered Nov 16, 2016 at 14:04

Sampath

66.2k70 gold badges329 silver badges462 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jpk · Accepted Answer · 2016-11-16 13:26:38Z

2

the changes to entities are monitored internally, therefore none of your changes should be lost as long as you did not tell the entity framework to skip the change tracking (e.g. using AsNotracking() in your query)

answered Nov 16, 2016 at 13:26

jpk

813 bronze badges

Collectives™ on Stack Overflow

Entity Framework - Loop then call SaveChanges

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related