"ReferenceError: window is not defined" when compiling with r.js

Question

I've been using RequireJS and it works perfectly. I use a lot of "window.document" to manipulate different DOM elements, but when I try to optimize it with r.js i get a ReferenceError: window is not defined which only happens with r.js.

Here is a minimal example of code that reproduces the issue:

index.html:

<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
</head>
<body >
<div id="commentbox">

</div>
<script data-main="code/main" src="code/require.js"></script>
</body>
</html>

main.js:

 require(["roomManager"], function (roomManager){
 return {

 }
 });

roomManager.js:

define(["commentManager"], function(commentManager){
    var commentHand = new commentManager.commentHand();
    commentHand.init();


    return{

    }
});

commentManager.js:

define([], function(){
    function commManager(getDisplayIdVariable){
        var messagebox = window.document.getElementById("commentbox");

        this.init = function(){
            messagebox.innerHTML = "hi!";
        }
    }
return{
        commentHand : commManager
}
});

This version works correctly without r.js but when I try to compile it by running r.js main.js. I get this:

var messagebox = window.document.getElementById("commentbox);


ReferenceError: window is not defined
         at new new commManager

Louis · Accepted Answer · 2016-11-21 13:43:12Z

2

You cannot just do r.js main.js.

For one thing, you have to specify -o so that r.js performs the optimization. (r.js can be used for other things.)

You also have to pass configuration to r.js, either in a file, or on the command line. One possibility for you would be:

r.js -o name=main out=built.js

I've tried this with the code you show in your question and I get no errors.

I strongly suggest going over this documentation for r.js.

answered Nov 21, 2016 at 13:43

Louis

152k28 gold badges289 silver badges332 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

orellabac · Accepted Answer · 2019-07-02 23:49:44Z

0

if your code is optional you can use

 if (typeof window !== 'undefined') { 
       // Inside browser
} 
{
  // outside browser
}

answered Jul 2, 2019 at 23:49

orellabac

2,7682 gold badges33 silver badges44 bronze badges

Collectives™ on Stack Overflow

"ReferenceError: window is not defined" when compiling with r.js

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related