How to lint specific function call in JavaScript?

Question

My team has had the occasional problem of developers pushing Karma/Protractor tests containing the .only() function call, which of course makes our Jenkins etc only run that particular test, potentially allowing bugs to slip by. As such I thought I'd try and figure out a way to stop this from happening without being discovered.

First, I thought I'd look into simply using JSHint to point out the function call, but I can't seem to find a way to do that. I also looked at ESLint for its custom plugins, but I can't figure out how to write a plugin for this particular case.

Could you guys give me some ideas on how to solve this issue? Alternative solutions are also appreciated, of course!

Write your own rule/plugin npmjs.com/package/generator-eslint — Ruan Mendes
– Ruan Mendes, Commented Nov 28, 2016 at 15:09

Ruan Mendes · Accepted Answer · 2016-11-28 15:32:04Z

1

Here's a (probably not working example) of how to create a plugin that flags an error if the parser ever sees a only() call. Again, mileage may vary, but it should be enough to get you started. This does not work if it sees a.only(), we'll leave that up to you.

module.exports.rules = {
    "no-only-call": context => ({
        CallExpression: (node) => {
            if(node.callee.name == "only"){
                context.report(node, 'Calls to only() are disallowed');
            }
        }
    })
};

https://www.kenneth-truyers.net/2016/05/27/writing-custom-eslint-rules/ - Simple example of creating a custom rule
http://esprima.org/demo/parse.html - Use this online parser to help you understand the parse tree.
https://www.npmjs.com/package/generator-eslint - Use this generator to start your plugin project

edited Nov 28, 2016 at 15:32

answered Nov 28, 2016 at 15:26

Ruan Mendes

92.7k31 gold badges162 silver badges225 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to lint specific function call in JavaScript?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related