Maximum call stack size exceeded on SetTimeout recursive function (Javascript) [duplicate]

Question

I have a recursive SetTimeout function that clicks a filter on my page after the filters have loaded (they're loaded through Ajax, so not available immediately on page load).

$scope.clickFilter = function () {
    var filter = $('.filter-item')
        .find('input[value="' + $scope.activeFilter + '"]');

    if (filter.length < 1) {
        setTimeout($scope.clickFilter(), 1000);
    } else {
        $(filter).trigger("click");
    }
}

However, when the filters take a long time to load, I get "Uncaught RangeError: Maximum call stack size exceeded(…)"

How do I prevent this and make sure it runs until completion?

Pointy · Accepted Answer · 2016-12-01 14:43:00Z

3

The problem is here:

  setTimeout($scope.clickFilter(), 1000);

Putting () after the function reference means that you want the function to be called, immediately, at that point in the code. What you probably want instead is something like:

  setTimeout($scope.clickFilter.bind($scope), 1000);

which will

pass a function reference to setTimeout(), as is required, and
ensure that the function will be invoked with the proper this value (what the .bind() part does)

Once you get it working, the term "recursive" isn't really appropriate. Yes, the function is referencing itself when it arranges for the call after the timer expires, but it's not directly calling itself; it's asking something else (the timer mechanism) to call it later.

edited Dec 1, 2016 at 14:43

answered Dec 1, 2016 at 14:40

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

T.J. Crowder Over a year ago

You know this is a duplicate... :-)

Pointy Over a year ago

@T.J.Crowder there are times in the morning when I'm just not up to dealing with the bizarre SO search. Yes, it's a dup of course.

Collectives™ on Stack Overflow

Maximum call stack size exceeded on SetTimeout recursive function (Javascript) [duplicate]

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related