No error message displayed for custom validator

Question

I have a requirement that one of multiple fields is required. Using custom validator the even fires, false is returned, but no error message is display and the form validates.

What am I missing? I have tried with and without ValidationSummary.

Thanks!

<asp:CustomValidator ID="CustomValidator1" OnServerValidate="validatePhone" EnableClientScript="false" runat="server" ErrorMessage="Home or Cell Phone is Required" ></asp:CustomValidator>

<asp:ValidationSummary ID="ValidationSummary1" DisplayMode="BulletList"  runat="server" ForeColor="Red" Font-Size="X-Small" Font-Bold="true" />


protected void validatePhone(object sender, ServerValidateEventArgs e)
    {
        e.IsValid = string.IsNullOrEmpty(txtCellPhone.Text) && string.IsNullOrEmpty(txtHomePhone.Text) ? false : true;
    }

A_Nabelsi · Accepted Answer · 2010-11-03 23:00:12Z

1

You have to set the ControlToValidate to some TextBox.

<asp:CustomValidator ID="CustomValidator1" OnServerValidate="validatePhone" EnabEnableClientScript="false" runat="server" ErrorMessage="Home or Cell Phone is Required" ControlToValidate="txtHomePhone"/>

edited Nov 3, 2010 at 23:00

answered Nov 3, 2010 at 22:54

A_Nabelsi

2,57418 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bleeped Over a year ago

Setting ControlToValidate will not validate if the control is empty. Since I am validating multiple controls this will not work.

Jon P · Accepted Answer · 2010-11-04 00:57:02Z

1

Check out this article. Basically you need to wire up the client side validation. Add the following just before the closing form tag changing the control names as needed:

<%-- This configures the validator to automatically--%> 
<%-- update when either of these controls is changed --%>
<script type="text/javascript">
   <!--
      ValidatorHookupControlID("<%= MyControl1.ClientID %>", 
      document.getElementById["<%= CustomValidator1.ClientID %>"]);
      ValidatorHookupControlID("<%= MyControl2.ClientID %>", 
      document.getElementById["<%= CustomValidator1.ClientID %>"]);
   //-->
</script>

Alternatively use this control

answered Nov 4, 2010 at 0:57

Jon P

19.9k8 gold badges52 silver badges76 bronze badges

Comments

Bleeped · Accepted Answer · 2010-11-04 15:49:55Z

1

Issue was completely my fault. On my submit button the final thing I do is a Response.Redirect. The message was coming up, but then the Thank you page was being presented. Now only doing the Response.Redirect if the customvalidator returns true.

answered Nov 4, 2010 at 15:49

Bleeped

4697 silver badges16 bronze badges

1 Comment

rtpHarry Over a year ago

You should only do process the code if Page.IsValid = true. That checks all validators in the ValidationGroup are valid. Otherwise you can bypass validation by messing with the JavaScript.

Collectives™ on Stack Overflow

No error message displayed for custom validator

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related