Javascript ternary operator with empty 2nd expression [closed]

Question

Closed. This question is opinion-based. It is not currently accepting answers.

Want to improve this question? Because this question may lead to opinionated discussion, debate, and answers, it has been closed. You may edit the question if you feel you can improve it so that it requires answers that include facts and citations or a detailed explanation of the proposed solution. If edited, the question will be reviewed and might be reopened.

Closed 9 years ago.

Improve this question

I've looked at somewhat similar questions like this or this but they are answering a different question as they look at assignment operations. For example my code is

!item.completed ? addTask(item) : null

as I would like to execute a certain function if condition is met or do nothing if it's not met. My question is what would be considered a good practice to pass as an 'empty' 2nd expression?

I saw a lot of people using null, on the other hand I think that using an empty string '' is also a valid option as since there is no assignment happening an empty string is faster to type and doesn't seem to have any cons.

The ternary operator isn't appropriate here if there is no third thing. Just use an if. — user47589
– user47589, Commented Dec 2, 2016 at 20:53
why not just use if? if minification is your goal then '' is better — Alexander Taran
– Alexander Taran, Commented Dec 2, 2016 at 20:53
I'm voting to close this question as off-topic because it belongs on codereview but I can't transfer there. — Joshua
– Joshua, Commented Dec 3, 2016 at 4:15

Nina Scholz · Accepted Answer · 2016-12-02 20:53:51Z

15

You could use logical or ||

item.completed || addTask(item)

answered Dec 2, 2016 at 20:53

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Anton Kastritskiy Over a year ago

Never thought about the OR operator in this way, thank you for opening the new use for it

plalx · Accepted Answer · 2016-12-02 20:54:17Z

3

I think this is not a good use of the ternary operator.

I'd either do:

if (!item.completed) addTask(item);

Or

!item.completed && addTask(item);

answered Dec 2, 2016 at 20:54

plalx

43.8k7 gold badges77 silver badges94 bronze badges

Comments

Cjmarkham · Accepted Answer · 2016-12-02 20:56:40Z

1

You could use:

!item.completed && addTask(item);

There's no point using a ternary if you don't need it.

edited Dec 2, 2016 at 20:56

Cjmarkham

9,7336 gold badges52 silver badges85 bronze badges

answered Dec 2, 2016 at 20:54

TigOldBitties

1,3359 silver badges15 bronze badges

Collectives™ on Stack Overflow

Javascript ternary operator with empty 2nd expression [closed]

3 Answers 3

1 Comment

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Linked

Related