Java : Recursive Depth First Traversal

Question

Can someone point out what is wrong with my code? From what I observed, return root doesn't work properly as it should.

private Node find(String name, Node root)
  {
    if (root != null)
    {
      if (root.name.equals(name)){
        System.out.println(root.name);
        return root;
      }
      find(name, root.father);
      find(name, root.mother);
      System.out.println(root.name + "This");
    }
    return null;
  }

  public void addParents(String ego, String father, String mother)
  {
    Node temp = find(ego);
    if (temp == null)
      throw new IllegalArgumentException("No such name.");
    temp.father = new Node(father, null, null);
    temp.mother = new Node(mother, null, null);
    System.out.println(temp.name + " | " + temp.father.name + " | " + temp.mother.name);
  }

root.father and root.mother... that is one extremely weird tree structure. — Jim Garrison
– Jim Garrison, Commented Dec 5, 2016 at 6:32

CompSciFly · Accepted Answer · 2016-12-05 06:25:54Z

0

Edit your code as below:

Node n = find(name, root.father);
if (n!=null && n.name.equals(name))
{
    return n;
}
n = find(name, root.mother);
if (n!=null && n.name.equals(name))
{
    return n;
}

This will help you understand recursion, and then you can write it in a much better way.

Let me know if you still have issues.

edited Dec 5, 2016 at 6:25

CompSciFly

1803 silver badges19 bronze badges

answered Dec 5, 2016 at 6:00

Azodious

13.9k1 gold badge41 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marco A. Hernandez · Accepted Answer · 2016-12-05 11:26:24Z

0

You are making a recursive call that don't use the returned value. Try this:

public Node find(String name, Node root){

        Node findNode = null;

        if (root != null){
            if (root.name.equals(name)){
                System.out.println(root.name);
                return root;
            }

            findNode = find(name, root.father);

            if(findNode!=null){
                return findNode;
            }

            findNode = find(name, root.mother);

            if(findNode!=null){
                return findNode;
            }
        }               
        return null;            
      }

edited Dec 5, 2016 at 11:26

answered Dec 5, 2016 at 11:20

Marco A. Hernandez

8315 silver badges15 bronze badges

Collectives™ on Stack Overflow

Java : Recursive Depth First Traversal

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related