not sure why my python loop isn't working

Question

I have some text files (just using two here), and I want to read them in to Python and manipulate them. I'm trying to store lists of strings (one string for each word, one list each file).

My code currently looks like this: (files are named m1.txt and m2.txt)

dict={'m1':[],'m2':[]}

for k in files:        
with open(k,'r') as f:
        for line in f:
            for word in line.split():
                for i in range (1,3):
                    dict['m'+str(i)].append(word)

This code ends up combining the words in both text files instead of giving me the words for each file separately. Ultimately I want to read lots of files so any help on how to separate them out would be much appreciated!

What do you mean by combining? You only declared one dictionary, so of course they're all going to go into that dictionary. Are you trying to create multiple dictionaries, one for each file? — user3030010
– user3030010, Commented Dec 6, 2016 at 20:37
also you're appending words theoretically from m1.txt into dict['m2'] — depperm
– depperm, Commented Dec 6, 2016 at 20:39
also bad practice to use a built in word dict as a variable — MooingRawr
– MooingRawr, Commented Dec 6, 2016 at 20:39

stevieb · Accepted Answer · 2016-12-06 20:47:03Z

1

This example dynamically fetches the file name (without the extension) and uses it to denote where in the dict we're working:

files = ['m1.txt', 'm2.txt'];
file_store = {'m1':[],'m2':[]}

for file in files:
    prefix = (file.split(r'.'))[0]
    with open(file, 'r') as f:
        for line in f:
            for word in line.split():
                file_store[prefix].append(word)

answered Dec 6, 2016 at 20:47

stevieb

9,3263 gold badges28 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mba12 · Accepted Answer · 2016-12-06 20:57:09Z

1

You were opening each list repeatedly while processing each individual file by alternative i values in the final for loop.

Try something like this:

dict={'m1':[],'m2':[]}

for i, k in enumerate(files):        
    with open(k,'r') as f:
        for line in f:
            for word in line.split():
                dict['m'+str(i+1)].append(word)

I've left your code "as is" but the comment above regarding not using language keywords is important.

edited Dec 6, 2016 at 20:57

answered Dec 6, 2016 at 20:40

mba12

2,8027 gold badges41 silver badges59 bronze badges

1 Comment

Dan Over a year ago

Thanks for the help - I'll change the name of my dictionary as well.

Collectives™ on Stack Overflow

not sure why my python loop isn't working

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related