SQL insert query throws error

Question

This is how my table looks like

    /****** Object:  Table [dbo].[tdn_Winners]    Script Date: 08/12/2016 18:55:35 ******/
SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[tdn_Winners](
    [Id] [int] IDENTITY(1,1) NOT NULL,
    [MemberId] [int] NULL,
    [PrizeNodeId] [int] NULL,
    [CampaignNodeId] [int] NULL,
    [TransactionId] [int] NULL,
 CONSTRAINT [PK_TND_Winners] PRIMARY KEY CLUSTERED 
(
    [Id] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY]
) ON [PRIMARY]

GO

And I am inserting some values to this table like this

        string insertquery = "INSERT INTO [dbo].[tdn_Winners] ([MemberId] ,
    [PrizeNodeId] ,[CampaignNodeId] ,[TransactionId])  VALUES(@MemberId, 
    @PrizeNodeId, @CampaignNodeId, @TransactionId";


                int rowsAffected = sqlHelper.ExecuteNonQuery(insertquery, 
sqlHelper.CreateParameter(parameterName: "@MemberId", value: 1), 
sqlHelper.CreateParameter(parameterName: "@PrizeNodeId", value: 1),
sqlHelper.CreateParameter(parameterName: 
"@CampaignNodeId",value: 1), sqlHelper.CreateParameter(parameterName: 
"@TransactionId", value: 1));

Everything looks ok to me, But this throws an error like this

System.Data.SqlClient.SqlException: Incorrect syntax near '@TransactionId'.

Can anyone please point out what I am doing wrong here?

Your insert command is missing a closing parenthesis at the end ). — juharr
– juharr, Commented Dec 8, 2016 at 13:30

madoxdev · Accepted Answer · 2016-12-08 13:30:12Z

5

You are missing closing bracket:

 string insertquery = "INSERT INTO [dbo].[tdn_Winners] ([MemberId] ,
[PrizeNodeId] ,[CampaignNodeId] ,[TransactionId])  VALUES(@MemberId, 
@PrizeNodeId, @CampaignNodeId, @TransactionId)";

answered Dec 8, 2016 at 13:30

madoxdev

3,9301 gold badge26 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arulkumar · Accepted Answer · 2016-12-08 14:20:20Z

2

I think you are forgot to close the bracket.

VALUES(@MemberId, @PrizeNodeId, @CampaignNodeId, @TransactionId)";

edited Dec 8, 2016 at 14:20

Arulkumar

13.3k15 gold badges51 silver badges76 bronze badges

answered Dec 8, 2016 at 13:30

Midhun Mundayadan

3,1923 gold badges24 silver badges34 bronze badges

Comments

Arulkumar · Accepted Answer · 2016-12-08 14:18:18Z

0

The closing bracket after @TransactionId was missing.

Add it and retry. It should work.

   "INSERT INTO [dbo].[tdn_Winners] (
    [MemberId] ,
    [PrizeNodeId] ,
    [CampaignNodeId] ,
    [TransactionId]) 
     VALUES(
       @MemberId, 
       @PrizeNodeId, 
       @CampaignNodeId,
       @TransactionId)";

edited Dec 8, 2016 at 14:18

Arulkumar

13.3k15 gold badges51 silver badges76 bronze badges

answered Dec 8, 2016 at 13:55

Hanuma

411 silver badge4 bronze badges

Collectives™ on Stack Overflow

SQL insert query throws error

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related