Django form.save() not taking updated form.cleaned_data

Question

I'm lost here and can't figure out what I'm missing, which is probably something stupid, but I need another set of eyes because as far as I can tell this should be working.

What I'm trying to do is allow my users to enter phone numbers in ways they are used to seeing, but then take that input and get a validated international phone number from Twilio and save it. By definition that means it will be in the following format - which is the format I need to have it in the database so that it interacts well with another part of the application:

+17085551212

I've debugged to the point there I know the values are coming in correctly, everything works right if I get an invalid number, etc. For some reason, the updated value is not being passed back to the form when I set form.cleaned_data['office_phone'] prior to the form.save(). So I am getting the original number (708) 555-1212 in the database.

forms.py

class ProfileForm(forms.ModelForm):
    office_phone = forms.CharField(max_length=20, label="Office Phone")

views.py

if form.is_valid():
    print (form.cleaned_data['office_phone'])
    pn = form.cleaned_data['office_phone'].replace(" ","")
    try:
        response = validator.phone_numbers.get(str(pn))
        form.cleaned_data['office_phone'] = str(response.phone_number)
        print form.cleaned_data
        form.save()
        success_message = "Your changes have been saved"
    except:
        error_message = "The contact phone number you entered is invalid."

console.output

(708) 555-1212
+17085551212
+17085551212
{'office_phone': '+17085551212'}
<tr><th><label for="id_office_phone">Office Phone:</label></th>
<td><input id="id_office_phone" maxlength="20" name="office_phone" type="text" value="(708) 555-1212" /></td></tr>

What am I missing here?

Apoorv Kansal · Accepted Answer · 2016-12-10 02:50:13Z

1

Made an edit: I realise that instead of overriding save, we should instead clean/validate the phone number by using custom validation:

class ProfileForm(forms.ModelForm):
    office_phone = forms.CharField(max_length=20, label="Office Phone")  

    def clean_office_phone(self):
        value = self.cleaned_data.get("office_phone")
        try:
            value = value.replace(" ", "")
            response = validator.phone_numbers.get(str(value))

        except:
            raise ValidationError("The contact phone number you entered is invalid")

        return str(response.phone_number)

views.py:

if form.is_valid():
        form.save()
        success_message = "Your changes have been saved"

edited Dec 10, 2016 at 2:50

answered Dec 10, 2016 at 0:39

Apoorv Kansal

3,3106 gold badges29 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

f71316 Over a year ago

How will this handle an error case if the validator returns a 404 (invalid phone number) instead of coming back with a valid phone number? Also, not sure I understand the if commit: instance.save() return instance Tried it anyway and now it doesn't even seem to be saving changes. Yep, the save always fails. going to try troubleshooting it, but not sure.

f71316 Over a year ago

Troublehooting the above and got it to work, but still don't understand why. Can you explain why this works here instead of just having the working code in the view?

Apoorv Kansal Over a year ago

Can you try the new edit? I have made major changes because I feel like the first answer was not the right way to go. Since you are "cleaning" and validating the phone number, we should use custom validation instead.

f71316 Over a year ago

I have not tried what you edited your answer to - even though it may be the right way. I did get it working with the previous information you had in there. I don't know if you can, but I think you should put that back and then add this answer below it rather than replace the answer that worked.

Collectives™ on Stack Overflow

Django form.save() not taking updated form.cleaned_data

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related