how to stop data automatically insert into database in php

Question

I have problem in this code. In this code when i press save data button , the data insert into database but when i refresh page then it's automatically insert into database, what should i do in my code then stop automatically insert data into database, thanks in advance

<?php 
require './database/databaseConnection.php';

if(isset($_POST['save_button']))
    {   
    if(($_POST['fname']&&($_POST['lname'])))
        {
        $first_name=$_POST['fname'];
        $last_name=$_POST['lname'];
        $qry="INSERT INTO user_master(first_name,last_name) values('$first_name','$last_name')";
        $result=  mysql_query($qry)or die(mysql_error());
        if($result){           
            echo 'SuccessFully saved data';            
        }
        else{   
            echo 'Data Not Inserted!';            
        }       
        }   
    }
?>

<!DOCTYPE html>
<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <title></title>
        <link rel="stylesheet" href="bootStrap/css/bootstrap.min.css">
                <link rel="stylesheet" href="bootStrap/css/bootstrap.css">
    </head>
    <body>
        <div class="container jumbotron ">

            <form action="" method="post">
             <table class="table-responsive">
            <div class="form-group form-inline">

                    <tbody> 
                    <tr>
               <td> <label for="fname" class="label-info">First Name</label></td>
                <td><input class="form-control" type="text" name="fname"></td>

                <td><label for="lname" class="label-info">Last Name</label></td>
                <td><input class="form-control" type="text" name="lname"></td>

                </tr>       
                    </tbody>

            </div>     
             </table>             
                <button type="submit" name="save_button" class="btn-success" >Save Data</button>   
   </form>            

        </div>

    </body>
</html>

this code will not save automaticallyl on refresh. Please post the actual code. Secondly you shouldn't be using mysql_* — e4c5
– e4c5, Commented Dec 16, 2016 at 2:56
You are wide open to SQL injection. Also, please don't use mysql_*; the mysql_* functions are outdated, deprecated, and insecure. They were removed entirely in PHP 7. Use MySQLi or PDO instead.* — elixenide
– elixenide, Commented Dec 16, 2016 at 3:00
Possible duplicate of how to stop reenter data into database when page refresh — Mr Lister
– Mr Lister, Commented Dec 19, 2016 at 5:33

ab29007 · Accepted Answer · 2016-12-16 03:04:14Z

2

This is happening because your action is empty

Update your action to this

action="<?php echo $_SERVER['PHP_SELF']; ?>"

answered Dec 16, 2016 at 3:04

ab29007

7,7662 gold badges20 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jophab · Accepted Answer · 2017-08-20 12:11:36Z

1

Make a separate php file that will insert data to database. Give this in the form action attribute.

<form action="insert.php" method="post">
     ......
     ......
</form>

insert.php file

<?php 
require './database/databaseConnection.php';

if(isset($_POST['save_button']))
    {   
    if(($_POST['fname']&&($_POST['lname'])))
        {
        $first_name=$_POST['fname'];
        $last_name=$_POST['lname'];
        $qry="INSERT INTO user_master(first_name,last_name) values('$first_name','$last_name')";
        $result=  mysqli_query($qry)or die(mysql_error());
        if($result){           
            echo 'SuccessFully saved data';            
        }
        else{   
            echo 'Data Not Inserted!';            
        }       
        }   
    }
?>

You can use header() to redirect to your previous page if you want. Thus not allowing the refreshing of insert.php

header("location: your_page.php");

it will be safe if you use Prepared Statements Take a look

edited Aug 20, 2017 at 12:11

answered Dec 16, 2016 at 2:56

jophab

5,54714 gold badges45 silver badges61 bronze badges

1 Comment

e4c5 Over a year ago

yes, this is how it should be done. But still you are promoting mysql_* :)

Collectives™ on Stack Overflow

how to stop data automatically insert into database in php

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related