Javascript weird if else not working [duplicate]

Question

Anyone knows why showToast always pops up even if desiredquantity is greater than inventoryCount?

  function checkavailable(){
  var desiredquantity = document.getElementById("bin-Qty").value;
  var inventoryCount = document.getElementById("bin-binItem-quantity").value;
  var itemName = document.getElementById("bin-binItem").value;
  if(desiredquantity > inventoryCount)
  {
    console.log(desiredquantity);
    showToast('There are only ' +inventoryCount +' '+itemName+' left');
  }
  else
  {
    addToTransfer();
  }
}

I have a button to that calls checkavailable

<button type="button"
   onclick ="checkavailable();">
</button>

Convert the values read from DOM to Number. You can use Number, parseFloat, parseInt, Unary Plus, etc. Ex: parseInt(document.getElementById("bin-Qty").value, 10); — Tushar
– Tushar, Commented Dec 19, 2016 at 3:09

Anik Islam Abhi · Accepted Answer · 2016-12-19 03:10:20Z

1

Please convert it to number first

Like this

if (+desiredquantity > +inventoryCount) { // + will parse it as number
  console.log(desiredquantity);
  showToast('There are only ' + inventoryCount + ' ' + itemName + ' left');
} else {
  addToTransfer();
}

Or you can use parseInt if value is integer and if value float than use parseFloat

Like this

if (parseInt(desiredquantity) > parseInt(inventoryCount)) {
  console.log(desiredquantity);
  showToast('There are only ' + inventoryCount + ' ' + itemName + ' left');
} else {
  addToTransfer();
}

answered Dec 19, 2016 at 3:10

Anik Islam Abhi

25.4k8 gold badges61 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript weird if else not working [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related