User Class In OOP

Question

I was started my learing in OOP and I make a class but I have a problem now. This is my little code:

class User {

    public $name;
    public $age;
    public $city;

    public function setDate($setName, $setAge, $setCity) 
    {
        $this->name = $setName;
        $this->age = $setAge;
        $this->city = $setCity;
    }

    public function pullDate()
    {
        return $this->name;
        return $this->age;
        return $this->city;
    }

}

$newUser = new User;
$newUser->setDate('Adrian', '23', 'Poland');
echo $newUser->pullDate();

And when I get variable by echo $newUser->pullDate(); in response recerive only 'Adrian' ... How I can fix it?

Thanks for help!

Please edit your question and include tag for language you are using. — Dalija Prasnikar
– Dalija Prasnikar ♦, Commented Dec 22, 2016 at 11:24
It's not clear what language this is - but I would assume the first return statement returns from the function so never gets to the other two data items you want — doctorlove
– doctorlove, Commented Dec 22, 2016 at 11:27
You can not return more than one object or value!, instead of return multiple create an object of class and return it as object. — Rajesh
– Rajesh, Commented Dec 22, 2016 at 11:33

arkascha · Accepted Answer · 2016-12-22 11:35:44Z

1

A function can only return a single value. Placing multiple return statements in a row does not make any sense, the function will always return after the first such statement. Instead you have to combine the values, for example by creating an array out of them.

Take a look at this modified version, assuming that you are using php:

<?php 
class User {

    public $name;
    public $age;
    public $city;

    public function setDate($setName, $setAge, $setCity) 
    {
        $this->name = $setName;
        $this->age = $setAge;
        $this->city = $setCity;
    }

    public function pullDate() {
        return [
            'name' => $this->name,
            'age' => $this->age,
            'city' => $this->city
        ];
    }
}

$newUser = new User;
$newUser->setDate('Adrian', '23', 'Poland');
$userValues = $newUser->pullDate();
echo sprintf(
    "Name: %s, Age: %s, City: %s\n",
    $userValues['name'],
    $userValues['age'],
    $userValues['city']
);

An alternative would be to implement separate "getters" for each property:

class User {
    // ...
    public function getName() {
        return $this->name;
    }
    public function getAge() {
        return $this->age;
    }
    public function getCity() {
        return $this->city;
    }
    // ...
}

And then get the attributes one by one, just as desired, for example by doing:

echo sprintf(
    "Name: %s, Age: %s, City: %s\n",
    $newUser->getName(),
    $newUser->getAge(),
    $newUser->getCity()
);

edited Dec 22, 2016 at 11:35

answered Dec 22, 2016 at 11:26

arkascha

43.2k8 gold badges61 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adrian Over a year ago

Thanks for help! Previously i wrote getName, getAge, getCity but I thought it would be better to do it in one function.

arkascha Over a year ago

As demonstrated, both is possible. Classical "getters" are a well known pattern which gives a lotof freedom especially for later modifications. But sometimes an (additional) combined method comes in handy too ;-)

Collectives™ on Stack Overflow

User Class In OOP

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related