Android change value of variable on click

Question

this is my code

final boolean identifier = true;
        if (i2 > i){
            if (identifier){
                v5.setOnClickListener(new View.OnClickListener(){
                    @Override
                    public void onClick(View v) {
                        identifier = false;
                    }
                });
            }
            if (!identifier){
                v5.setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        identifier = true;
                    }
                });
            }
        }

but this doesnt seem to be working out fine. what i want is when v5 is clicked it will run a code that will change v5 onClicklistener

Android change value of variable on click : why identifier is final ? — ρяσѕρєя K
– ρяσѕρєя K, Commented Dec 22, 2016 at 12:42
im trying to make my view act as a switch on off. on the first click it will show contents and then on second click it will hide contents. the cycle continues like odd even — Gilbert Mendoza
– Gilbert Mendoza, Commented Dec 22, 2016 at 12:48
@ρяσѕρєя K it needs to be final because it was access inside onClickListener — Gilbert Mendoza
– Gilbert Mendoza, Commented Dec 22, 2016 at 12:50
final boolean identifier = true; would not allow to change value remove final — Rajesh
– Rajesh, Commented Dec 22, 2016 at 13:02

Sridhar · Accepted Answer · 2016-12-22 12:52:32Z

2

Try this.

  boolean identifier = false;

  v5.setOnClickListener(new View.OnClickListener(){
                @Override
                public void onClick(View v) {
                    if(!identifier){
                     // first click
                     identifier=true;
                    }else{
                    // secondclick
                     identifier=false;
                    }
                }
            });

answered Dec 22, 2016 at 12:52

Sridhar

6681 gold badge11 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Gilbert Mendoza Over a year ago

still the same. cant call identifier inside onClick if its not final and final variable doesnt seem to allow change of variable

Sridhar Over a year ago

make the identifier public and then try

Pushpendra Over a year ago

@GilbertMendoza define you identifier outside the method(from onCreate).

Gilbert Mendoza Over a year ago

sorry this code is within a void. i didnt post full code but i will try and if it works ill mark ur answer as correct

Pushpendra Over a year ago

@GilbertMendoza then define outside the void.

|

honk · Accepted Answer · 2016-12-22 13:05:30Z

2

Remove final from your identifier declaration, and make it a class private field so you can access it from your OnClickListener.

Set only one OnClickListener and have it check the value of identifier, like so:

v5.setOnClickListener(new OnClickListener(){
    @Override
    public void onClick(View v) {
        identifier = !identifier; // switch the value to false/true
        // update your UI
    }
});

edited Dec 22, 2016 at 13:05

honk

9,88311 gold badges83 silver badges90 bronze badges

answered Dec 22, 2016 at 12:52

marmor

28.3k12 gold badges111 silver badges152 bronze badges

Comments

Natheem Yousuf · Accepted Answer · 2016-12-22 12:51:20Z

0

int identifier = 0;
        if (i2 > i){ 
            if (identifier=0){
                v5.setOnClickListener(new View.OnClickListener(){
                    @Override 
                    public void onClick(View v) {
                        identifier = 1;
                    } 
                }); 
            } 
            if (identifier!=0){
                v5.setOnClickListener(new View.OnClickListener() {
                    @Override 
                    public void onClick(View v) {
                        identifier = 0;
                    } 
                }); 
            } 
        }

answered Dec 22, 2016 at 12:51

Natheem Yousuf

1432 gold badges2 silver badges8 bronze badges

1 Comment

Gilbert Mendoza Over a year ago

identifier needs to be final and final variable cannot change its value

FatherlyNick · Accepted Answer · 2020-12-14 22:07:10Z

0

Initialize the identifier boolean before the onCreate() method. Also don't make it final. A value of any Final variable cannot be modified.

boolean identifier = true;
...

onCreate() {
...
onClick() {
identifier = false;
//your code
...
 }
}

answered Dec 14, 2020 at 22:07

FatherlyNick

435 bronze badges

Collectives™ on Stack Overflow

Android change value of variable on click

4 Answers 4

8 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

8 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related