PHP MySQL can't write on table

Question

While the request completes without an error it doesn't write in the database. It connects to the database i've checked it.

This is my code:

<?php
$json = json_decode(file_get_contents("config.json"), true);
$dbuser = $json['dbuser'];
$servername = $json['dbip'];
$dbpass = $json['dbpass'];
$dbname = $json['dbname'];
$password = $_GET['password'];
$email = $_GET['email'];

// Create connection
$conn = mysqli_connect($servername, $dbuser, $dbpass);
mysql_select_db( $dbname );

// Check connection
if ($conn->connect_error) {
    die("Connection failed: " . $conn->connect_error);
} 

$sql = "INSERT INTO credentials (usermail, pass)
VALUES ($email, $password)";

?>

Example: http://localhost/php/[email protected]&password=ilovestackoverflow

It just doesn't do anything. Please if you have any ideas

Hopefully you are not using this code anywhere, it's very hack-freindly. You should not pass user/pass with $_GET. mysql_ is removed from the new PHP, and your statement is injection-prone: "INSERT INTO credentials (usermail, pass) VALUES ($email, $password)"; — Rasclatt
– Rasclatt, Commented Jan 1, 2017 at 17:12
Use $_POST, look at PDO or mysqli_, once using a new db library, prepare/bind your user input. — Rasclatt
– Rasclatt, Commented Jan 1, 2017 at 17:15

Rasclatt · Accepted Answer · 2017-01-01 17:16:14Z

1

you must quote strings like:

$sql = "INSERT INTO credentials (usermail, pass)
VALUES ('$email', '$password')";

edited Jan 1, 2017 at 17:16

Rasclatt

12.5k3 gold badges28 silver badges33 bronze badges

answered Jan 1, 2017 at 17:14

Bernd Buffen

15.1k2 gold badges27 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bernd Buffen Over a year ago

there is no mysqli_query($conn,$sql); at the end

NicktehPro Over a year ago

Solved! Thank you :)

Collectives™ on Stack Overflow

PHP MySQL can't write on table

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related