Cannot access global variable from within class constructor

Question

Alright so I am trying to simply check if there is something inside the array from construct but it doesnt seem to work at all...

    $DB_VALID = array("mysql");

    class DB {
        function __construct($conn) {
            if(in_array($conn,$DB_VALID)) {
                echo "exists!";
            }
            else {
                echo "doesnt exist";
            }
        }
    }

Now, since construct is inside a class, if I dump it I will get results saying NULL, but if I dump it outside the construct I will simply get the real results...

Usage

$conn = new DB("mysql");

Results? in_array returns false

Possible duplicate of Use a variable from __construct() in other methods — tyteen4a03
– tyteen4a03, Commented Jan 4, 2017 at 3:11

DfKimera · Accepted Answer · 2017-01-04 03:17:09Z

2

The variable $DB_VALID does not exist inside the __construction function scope.

The recommended solution is that you move $DB_VALID to a static variable inside the DB class, as such:

class DB {
    static $DB_VALID = array("mysql");

    function __construct($conn) {
        if(in_array($conn,self::$DB_VALID)) {
            echo "exists!";
        }
        else {
            echo "doesnt exist";
        }
    }
}

You can later access that array in other parts of your code by referencing it as DB::$DB_VALID.

However, if you must keep the global variable and access it from within __construct, you can use the global keyword to bring it into the local scope, as such:

$DB_VALID = array("mysql");

class DB {
    function __construct($conn) {
        global $DB_VALID; // Brings the global variable to local scope
        if(in_array($conn,$DB_VALID)) {
            echo "exists!";
        }
        else {
            echo "doesnt exist";
        }
    }
}

Please consider the first solution on the future, though, as using global variables is an easy way to have your applications break as they evolve.

Edit: As you mentioned in the comments your restriction is the order you're loading your scripts right now, you should also really look into class autoloading and namespaces, as your projects will get increasingly complex and harder to manage otherwise (see sitepoint.com/autoloading-and-the-psr-0-standard).

edited Jan 4, 2017 at 3:17

answered Jan 4, 2017 at 3:02

DfKimera

2,1662 gold badges21 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Tomislav Nikolic Over a year ago

But is there any other way I can have it outside the scope itself? Way to make it global or such. I dont want of it to be inside the class itself thats the main problem

DfKimera Over a year ago

Sorry, just edited to clear that up. You can reference it by using DB::$DB_VALID elsewhere in the code (as long as the class is included beforehand or autoloaded).

Tomislav Nikolic Over a year ago

The problem is, I am using a separate php file to include that array (with many other things of course) so therefore using it inside the class itself is somewhat impossible at the moment, I really want to keep it outside of it

DfKimera Over a year ago

You should really look into class autoloading and namespaces, as your projects will get increasingly complex and harder to manage otherwise (see sitepoint.com/autoloading-and-the-psr-0-standard). However, you can quickly fix your case by adding global $DB_VALID inside __construct so the global variable is imported to the function scope. I should warn you, this is really not recommended, and goes against best practices.

user557846 Over a year ago

you parse "mysql" in to the class, you could do exactly the same with the array $conn = new DB("mysql",$DB_VALID);

|

tyteen4a03 · Accepted Answer · 2017-01-04 03:07:13Z

0

If you have to, use the global keyword.

$DB_VALID = array("mysql");

class DB {
    function __construct($conn) {
        global $DB_VALID; // Makes the variable available in the scope
        if(in_array($conn,$DB_VALID)) {
            echo "exists!";
        }
        else {
            echo "doesnt exist";
        }
    }
}

$conn = new DB("mysql"); // will print "exists!"

Note that global variables usually hints organisation problems, so you should probably review your structure and see if it's really necessary to use global here.

answered Jan 4, 2017 at 3:07

tyteen4a03

1,9432 gold badges27 silver badges51 bronze badges

1 Comment

user557846 Over a year ago

highly recomended NOT to use global

Collectives™ on Stack Overflow

Cannot access global variable from within class constructor

2 Answers 2

7 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related