Efficient use of trim and split for strings in Java

Question

The code I wrote here works, but I am pretty sure it is awful and not so efficient. This function takes in input a list of strings which is splitted on comma and then each generated string is trimmed.

One example:

INPUT:    [[Cat, Dog, Snake]]
OUTPUT:   Cat Dog Snake

private List<String> splitListOfString(LinkedList<String> list)
{
    String mylist = list.toString();
    mylist = mylist.substring(2);
    mylist = mylist.substring(0, mylist.length() - 2);
    List<String> thelist = Arrays.asList(mylist.split(","));
    List<String> thelist2 = new LinkedList<String>();
    for (String string : thelist) {
        thelist2.add(string.trim());
    }
        return thelist2;
}

How would you improve this code?

The code I wrote here works -- Seems like you could use a CodeReview codereview.stackexchange.com/tour — OneCricketeer
– OneCricketeer, Commented Jan 22, 2017 at 19:43
Why is your input a List of strings and not just a single string? What exactly are the elements of this list? — Frank Puffer
– Frank Puffer, Commented Jan 22, 2017 at 19:44
Is your input ["[Cat", "Dog", "Snake]"] (size 3) or ["[Cat, Dog, Snake]"] (size 1)? My guess is the latter, but ... why? — Andreas
– Andreas, Commented Jan 22, 2017 at 19:49
Hint: A "list of strings" doesn't need to be toString()-d. You already have a list, so iterate over it, trim() the values, — OneCricketeer
– OneCricketeer, Commented Jan 22, 2017 at 19:49
Please check out minimal reproducible example (guidance on providing code in the post) and provide input data for code in the post. As @cricket_007 commented toString call on list is very confusing - so hard to say why it is there and if removal will actually make code easier for data you have. — Alexei Levenkov
– Alexei Levenkov, Commented Jan 22, 2017 at 23:29

Joe C · Accepted Answer · 2017-01-22 19:48:56Z

2

How about simply streaming and collecting to a list?

return list.stream().map(String::trim).collect(Collectors.toList());

answered Jan 22, 2017 at 19:48

Joe C

15.8k8 gold badges42 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Efficient use of trim and split for strings in Java

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related