Invalid format String containing %

Question

I've read others posts about this link warning but they didn't solve my problem and I still don't get what I've doing wrong.

In default file strings.xml, I have:

 <string name="rating_dialog">You\'re about to rate this app with %s stars.</string>

Later, I call it inside an override onClick method:

 v.getContext().getString(R.string.rating_dialog, String.valueOf(rating))

It's appearing like:

You're about to rate this app with {String.valueOf(rating)} stars.

Link Warning:

Format string is not a valid format string so it should not be passed to string.format

Note:

v is a View and rating is an int value.

I've checked other strings.xml files for other languages, and all translations seems alright.

Solved: for hindi string.xml, instead of %s, there was only %.

In string resources, you need to use %1$s (and %2$s etc.. for further variables) — 0xDEADC0DE
– 0xDEADC0DE, Commented Feb 2, 2017 at 9:51
It has been answered here: stackoverflow.com/questions/12627457/… — Dusan Jovanov
– Dusan Jovanov, Commented Feb 2, 2017 at 9:53

StuStirling · Accepted Answer · 2017-02-02 09:59:26Z

0

You need to assign a position to each placeholder you define in your XML.

Your string then becomes:

<string name="rating_dialog">You\'re about to rate this app with %1$s stars.</string>

answered Feb 2, 2017 at 9:59

StuStirling

16.3k24 gold badges98 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

whynottodayhum Over a year ago

Thank you, I applied this (and checked untranslatable so translations can't have a impact) but still the same problem.

KishuDroid · Accepted Answer · 2017-02-02 10:05:48Z

0

You can do it like below:

In string.xml:

If you want to assign integer value then use "%1$d" and if String then use "%1$s"

1 is use for defining position. If you want to use multiple values then you can use "%1$d","%2$d",....etc

<string name="rating_dialog">You\'re about to rate this app with %1$d stars.</string>

Then in code do it like :

v.getContext().getString(R.string.rating_dialog, rating);

Hope it helps you.

answered Feb 2, 2017 at 10:05

KishuDroid

5,4494 gold badges32 silver badges47 bronze badges

3 Comments

whynottodayhum Over a year ago

Thank you, I applied all your steps, with %1$d and %1$s and checked "untranslatable" in Translations Editor (so translations can't have a impact) but still the same problem.

KishuDroid Over a year ago

can you please try like String message = getString(R.string.rating_dialog, rating); ?

whynottodayhum Over a year ago

The problem was the hindi strings.xml, instead of %s, there was only %. But thank you again

Collectives™ on Stack Overflow

Invalid format String containing %

2 Answers 2

1 Comment

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related