Initialize a list of class in constructor returns overflow exception in c#

Question

I have a simple class ,and i want to initialize it in the constructor as you can see here:

 public class CameraSetting
    {

        public  string CameraIP { set; get; }
        public  string CameraType { set; get; }
        public int CameraGroup { set; get; }
        public string GateId { set; get; }

        public List<CameraSetting> MyList { set; get; }
        public CameraSetting()
        {
            MyList = new List<CameraSetting>()
            {
                new CameraSetting() { CameraIP = "192", CameraGroup = 0, CameraType = "ورود",GateId = "1"},
                new CameraSetting() { CameraIP = "193", CameraGroup = 0, CameraType = "خروج",GateId = "1"},
                new CameraSetting() { CameraIP = "194", CameraGroup = 1, CameraType = "ورود",GateId = "2"},
                new CameraSetting() { CameraIP = "195", CameraGroup = 1, CameraType = "خروج",GateId = "2"}

            };
        }
    }

In my code i call CameraSetting obj=new CameraSetting();.but it returns this error :

{"Exception of type 'System.StackOverflowException' was thrown."}

You're recursively calling the constructor inside of the constructor. — juharr
– juharr, Commented Feb 9, 2017 at 4:18

Leo · Accepted Answer · 2017-02-09 04:39:02Z

1

It's because each constructor creates four instances of the same type and the operation never ends. This is the order in which it happens...

You create CameraSetting 1
Then, CameraSettings instantiate 4 other CameraSettings
Then, each of these CameraSettings create another 4 CameraSettings EACH! That is, 4 * 4 = 16
Repeat indefinitely until the runtime kills the process with a StackOverflowException

edited Feb 9, 2017 at 4:39

answered Feb 9, 2017 at 4:18

Leo

14.9k2 gold badges44 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Corey Over a year ago

Minor correction... each call to the constructor calls the same constructor recursively until you run out of stack space. The 4 * 4 * 4 * ... series is not realized as each step in the process will recurse once, never returning to do the second.

sujith karivelil · Accepted Answer · 2017-02-09 04:25:20Z

Each time when you create an object of CameraSetting to add items to List, the constructor is invoked which forms a infinite loop here and that cause the exception.

I think it's better to take the List from the class and define it somewhere else as you needed. It is fine to use Like this in your main or some other places as required:

static void Main(string[] args)
{
    List<CameraSetting> _MyList = new List<CameraSetting>()
    {
        new CameraSetting() { CameraIP = "192", CameraGroup = 0, CameraType = "ورود",GateId = "1"},
        new CameraSetting() { CameraIP = "193", CameraGroup = 0, CameraType = "خروج",GateId = "1"},
        new CameraSetting() { CameraIP = "194", CameraGroup = 1, CameraType = "ورود",GateId = "2"},
        new CameraSetting() { CameraIP = "195", CameraGroup = 1, CameraType = "خروج",GateId = "2"}
    };
  // Rest of code here
}

Collectives™ on Stack Overflow

Initialize a list of class in constructor returns overflow exception in c#

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related